[FEATURE] Option to publicly show claimed names#627
Open
mzwoelfer wants to merge 7 commits intocmintey:mainfrom
Open
[FEATURE] Option to publicly show claimed names#627mzwoelfer wants to merge 7 commits intocmintey:mainfrom
mzwoelfer wants to merge 7 commits intocmintey:mainfrom
Conversation
mzwoelfer
changed the title
Owner
|
Makes sense. Will review tomorrow, but looks good from a quick glance |
Owner
|
This looks good and functions how I would expect. However, I'm going to hold off on merging any frontend changes until I can get the project migrated to the latest version of Skeleton [#426]. I'm nearing the end of this massive PR so I don't want to introduce new conflicts while I finish up |
Owner
|
@mzwoelfer I've merged the new version of skeleton. As expected, there are some conflicts. Please pull in the main branch and fix them and I'll review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDEA:
Host one instance, send link to friends & family.
No login required.
When more people want to gift together, they can now see the person that claimed the gift and contact them individually.
IMPROVEMENT:
Added toggle in claims settings to show claimed names publicly.
Still respects "List owner can not see claims" setting.