[C3] Gate frameworks E2E tests to merge queue, release branch, or label#13371
Open
petebacondarwin wants to merge 3 commits intomainfrom
Open
[C3] Gate frameworks E2E tests to merge queue, release branch, or label#13371petebacondarwin wants to merge 3 commits intomainfrom
petebacondarwin wants to merge 3 commits intomainfrom
Conversation
Only run C3 frameworks E2E tests when: - The trigger is merge_group (merge queue) - The branch is changeset-release/main (release PR) - The PR has the run-c3-frameworks-tests label This reduces CI time on regular PRs where frameworks tests are not needed. The cli and workers E2E tests continue to run unconditionally. Also splits the Windows include into explicit cli/workers entries since frameworks tests are already skipped internally on Windows.
|
workers-devprod
requested review from
a team and
edmundhung
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@petebacondarwin Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
The job-level if: condition read labels from the event payload, which is stale on workflow re-runs triggered by rerun-remote-tests.yml. Replace with a runtime step that uses 'gh pr view' to check for the run-c3-frameworks-tests label, matching the pattern used by check-remote-tests/action.yml in the Wrangler and Vite E2E workflows. All expensive steps (install, build, test, upload) are gated on the runtime check output so the job exits cheaply when skipped.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
petebacondarwin
added
the
run-c3-frameworks-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate C3 frameworks E2E tests so they only run during CI in the following cases:
merge_grouptrigger (merge queue)changeset-release/mainbranch (release PR)run-c3-frameworks-testslabel attachedThis reduces CI time on regular PRs where frameworks E2E tests are not needed. The
cliandworkersE2E tests continue to run unconditionally on every PR.Changes
.github/workflows/c3-e2e.yml:"frameworks"from thee2ejob's matrix filter list (["cli", "workers", "frameworks"]->["cli", "workers"])includeentry into explicitcliandworkersentries (frameworks tests are already skipped internally on Windows)frameworks-e2ejob with a conditional gate that only runs when the three conditions above are met.github/workflows/rerun-remote-tests.yml:rerun-c3-frameworksjob that re-triggers the C3 E2E workflow when therun-c3-frameworks-testslabel is added to a PR