Skip to content

chore(local-explorer-ui): Refine workflows page layout#13361

Merged
NuroDev merged 30 commits intomainfrom
NuroDev/local-explorer-workflows-ui
Apr 12, 2026
Merged

chore(local-explorer-ui): Refine workflows page layout#13361
NuroDev merged 30 commits intomainfrom
NuroDev/local-explorer-workflows-ui

Conversation

@NuroDev
Copy link
Copy Markdown
Member

@NuroDev NuroDev commented Apr 9, 2026

Fixes N/A.

Summary

  • Moved buttons & dropdowns to a single unified header
  • Updated workflow instance page responsive layout for smaller screens (Not entirely needed but better to have it than not need it)
  • Updated the workflows refresh button to add a minimum delay (Makes sure the loading spinner gets shown)
  • Ran the workspace prettify script to format a number of other Local Explorer files
Screenshot 2026-04-09 at 2 49 51 pm Screenshot 2026-04-09 at 2 50 00 pm ---
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: UI tweaks. No UI snapshot testing implemented yet.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: WIP Experimental feature

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@NuroDev NuroDev self-assigned this Apr 9, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 9, 2026

🦋 Changeset detected

Latest commit: 7638afb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 10, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13361

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13361

miniflare

npm i https://pkg.pr.new/miniflare@13361

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13361

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13361

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13361

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13361

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13361

wrangler

npm i https://pkg.pr.new/wrangler@13361

commit: 7638afb

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

✅ All changesets look good

@pombosilva
Copy link
Copy Markdown
Contributor

Thank you! Just a nit: can the green in "Complete" label and step checkmark be tailwind's emerald-600*

@NuroDev
Copy link
Copy Markdown
Member Author

NuroDev commented Apr 10, 2026

can the green in "Complete" label and step checkmark be tailwind's emerald-600*

Actually the success colors here come directly from the Kumo color palette where the success variant uses green and success-tint variant uses emerald.

In that case, do we want to then switch this to use success-tint instead of success?

@NuroDev NuroDev marked this pull request as ready for review April 10, 2026 13:43
@NuroDev NuroDev marked this pull request as draft April 10, 2026 13:43
@workers-devprod workers-devprod requested review from a team and jamesopstad and removed request for a team April 10, 2026 13:43
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 10, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@NuroDev
Copy link
Copy Markdown
Member Author

NuroDev commented Apr 10, 2026

Switching this back to a draft until #13330 is merged which includes a fix for the failing local explorer e2e tests

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@NuroDev NuroDev marked this pull request as ready for review April 10, 2026 20:32
devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@jamesopstad jamesopstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One thing to tidy up, if possible, is adding some space between the pagination icon and info:

Image

I've also posted a couple of non-blocking comments from the Devin review. These are not directly related to the changes in this PR so can just be noted for a follow up.

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 12, 2026
@NuroDev
Copy link
Copy Markdown
Member Author

NuroDev commented Apr 12, 2026

These are not directly related to the changes in this PR so can just be noted for a follow up.

Going to make a note of the Devin comments above and fix them in a later PR so this change isn't blocked.

@NuroDev NuroDev merged commit a4f1d5c into main Apr 12, 2026
49 checks passed
@NuroDev NuroDev deleted the NuroDev/local-explorer-workflows-ui branch April 12, 2026 11:59
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants