Open
Conversation
Merging this PR will not alter performance
|
4de6850 to
e8b2333
Compare
exec APIimpl IntoIterator consistently
Collaborator
|
As a breaking change, I will leave this open to reconsider as part of a comprehensive redesign of the API rather than doing incremental breaks sporadically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
impl IntoIteratorconsistently in all APIs. This replaces two other patterns that were in use:Vec<T>parametersimpl Into<Option<Vec<T>>>Using a
Vec<T>parameter when only an iterable collection is an anti-pattern. UsingIntoIteratorinstead allows users to pass arrays by value instead since the function is now generic over all array sizes (among many other types).impl Into<Option<Vec<T>>>is also a poor practice. In every case where it was used,Some(vec![])andNonewhere treated the same, making theOptionwrapper redundant. SinceOptionimplements iterator, users passingNonewill see no change.This change is not backwards compatible, but most users will have to make little to no change to existing code.