Expose container instanceId in JS API#6528
Open
ghostwriternr wants to merge 2 commits intocloudflare:mainfrom
Open
Expose container instanceId in JS API#6528ghostwriternr wants to merge 2 commits intocloudflare:mainfrom
ghostwriternr wants to merge 2 commits intocloudflare:mainfrom
Conversation
Containers are ephemeral — they can be replaced after sleep, crash, or eviction. Users currently have no way to detect this and resort to writing marker files into the container filesystem. The Coordinator already assigns a unique placement_id to each container instance. This exposes it as ctx.container.instanceId, a readonly string property that changes whenever a new container is provisioned and is undefined when no container is running.
Verify instanceId is undefined when not running, a non-empty string when the container is healthy, undefined after destroy, and changes after a restart cycle.
ghostwriternr
force-pushed
the
feat/container-instance-id
branch
from
cfe50c6 to
410795d
Compare
Contributor
|
I believe we'd want an RFC and develop a further discussion on how we want to approach this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a readonly
instanceIdproperty toctx.containerthat exposes the container's placement_id — an opaque string that uniquely identifies the current container instance. It changes whenever a new container is provisioned (after sleep, crash, or eviction) and isundefinedwhen no container is running.This lets developers detect container replacement without resorting to writing marker files into the container filesystem.
instanceIdfollows the same lifecycle asrunning: it is populated from the status() RPC at construction, updated via a background task when start() resolves, and cleared when monitor() or destroy() fires. A lifecycle epoch counter guards against stale start responses writing back after the container has already been torn down.Part of a cross-repo change — the container engine must populate the new capnp field before this surfaces useful values.