Add github actions CI - #38
Merged
Merged
Conversation
AlecRosenbaum
marked this pull request as ready for review
June 18, 2025 19:50
tsx
approved these changes
Jun 19, 2025
| strategy: | ||
| matrix: | ||
| python-version: ["3.10", "3.11", "3.12", "3.13"] | ||
| redis-version: ["4.6.0", "5.3.0", "6.2.0"] |
Contributor
There was a problem hiding this comment.
I got confused at first and thought it's redis server versions. I suggest renaming it to redis-client-version instead.
|
|
||
| - name: Install Python dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip |
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install setuptools | ||
| pip install flake8 flake8-docstrings flake8-polyfill pep8 pep8-naming isort |
Contributor
There was a problem hiding this comment.
uv or requirements-lint.txt
I understand not wanting to blow the scope but we should also move to ruff in a separate PR
Contributor
Author
|
yep I'll work on other improvements (uv, ruff, pkg_resources) in separate PR's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports circleci to github actions. Also:
After this merges, someone with adequate permissions will have to disable the project in circleci