Make DateTime validator always return a datetime#66
Merged
AlecRosenbaum merged 2 commits intomasterfrom Sep 13, 2022
Merged
Conversation
add no_time_as_date args with default to False, to switch to old behaviour by setting to True, if False always return datetime if True return date when no time in the input
tsx
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #45
This change adds a kwarg to disable converting
datetime's todate's during validation if there's no time specified within the source string. Eventually this should be default behavior, but to avoid a breaking change it's just opt-in for now.A commit is cherry picked from #65, then some minor refactors (mostly to code style/naming) are made in a followup commit.