Clarify Node.js 22 server thread affinity#586
Draft
Felipellira wants to merge 1 commit into
Draft
Conversation
Author
|
I came to this conclusion after thoroughly testing the issue in various scenarios; when I couldn’t reproduce it, I went straight to the source code, analyzed it, and ran Codex + Claude to see if I’d missed anything, and it turns out my hunch was correct. |
Collaborator
|
Was this still even a thing in node 16? This might just be outdated in general. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies that the JavaScript thread-affinity workaround documented for Node.js callbacks applies to the default Node.js 16 server runtime.
Adds a note that resources using
node_version '22'no longer need to wrap server natives or event calls insetImmediatesolely after Node.js I/O callbacks or awaited Node.js operations.