Open
Conversation
Signed-off-by: Erik Play2Learn <fallbackerik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For implementing #1147.
As a first step I got the weather symbols I could find from the nerd fonts website. I decided to list them as escape sequences rather than symbols, because otherwise every developer who doesn't have nerd fonts installed will only see squares and have a hard time distinguishing one symbol from the other.
Unknown and Thunder Snow Showers didn't make it into the list as I didn't find a corresponding symbol.
As I don't have a running server side (with keys to weather api servers) I'm not sure how I could test changing the API to allow nerd fonts output.