Add support for the cmod_a7 35 board. - #190
Conversation
09bc45a to
40fd613
Compare
|
@bl0x It looks like you might have had a server timeout while CI was running. Try force pushing to your fork again. |
I have restarted the build. The issues seem to be caused by to small custom runner coordinator machine. We've bumped the machine parameters |
40fd613 to
edda3ac
Compare
|
I've added the snippet to the docs. |
|
@kgugala Am I still missing something to make this ready for merging? |
Signed-off-by: Bastian Löher <b.loeher@gsi.de>
…tix 35T. Signed-off-by: Bastian Löher <b.loeher@gsi.de>
|
@kgugala I can't accept or review the requested changes anymore. I did however add the documentation earlier. Checks seem to pass now. |
acomodi
left a comment
There was a problem hiding this comment.
@bl0x thanks for this PR!
Everything is fine with CI. Counter tests have indeed run correctly for the CMOD A7.
The only thing missing is adding a mapping for the CMOD A7 board in the docs generation, or else an empty tab will appear in the readthedocs page (https://symbiflow-examples--190.org.readthedocs.build/en/190/building-examples.html#counter-test)
You should add the mapping here as done for the other boards.
Signed-off-by: Bastian Löher <b.loeher@gsi.de>
|
I've added the mapping. It would be nice, if the documentation (README?) would tell which changes are needed in the documentation. |
I've got a new and shiny Cmod A7 to play with, so here ya go!