Fix:server on close on websocket only condition#910
Closed
xen-HendryZheng wants to merge 1 commit into
Closed
Conversation
chimurai
reviewed
May 23, 2026
|
|
||
| if (server && !this.serverOnCloseSubscribed) { | ||
| // subscribe to http 'close' event to close proxy socket on ws true | ||
| if (server && !this.serverOnCloseSubscribed && this.proxyOptions.ws === true) { |
Owner
There was a problem hiding this comment.
This fix is incorrect.
proxy server should listen to server close event.
regardless of ws: true being used or not
Owner
|
fix is incorrect. proxy should be configured and used correctly in the server |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #909
Motivation and Context
How has this been tested?
Types of changes
Checklist: