Skip to content

support for Erlang R19 - #105

Open
eryx67 wants to merge 18 commits into
chef:mainfrom
eryx67:master
Open

support for Erlang R19#105
eryx67 wants to merge 18 commits into
chef:mainfrom
eryx67:master

Conversation

@eryx67

@eryx67 eryx67 commented Mar 21, 2017

Copy link
Copy Markdown
Contributor

It seems that Erlang 19 has only one (typed) declaration for records in AST

@stevendanna

Copy link
Copy Markdown
Contributor

@eryx67 Thanks for the contribution!

Our DCO policy (read about it here: https://blog.chef.io/2016/09/19/introducing-developer-certificate-of-origin/) requires that your commit has a Signed-Off-By line affirming you agree to the DCO. You can add it to your existing commit by doing something like:

git commit --amend -s --no-edit

and then force-pushing to your branch.

cc @chef/erlangers for review

@markan

markan commented Aug 2, 2018

Copy link
Copy Markdown
Contributor

I was just looking at what it would take to update us to OTP 21 and saw this PR.
@eryx67 thank you for your work and I'd like to revive this PR if possible. Very sorry about it falling through the cracks.

Currently github is marking this as unmergable because not every commit has DCO and travis is failing. While some of the commits have DCO, not all do.

What I would suggest we do is break this PR up into a couple of pieces, each rebased on master, and updated to have DCO. I'm thinking something like this would work:

  • The update to R19
  • The connection arg improvements.
  • Update to OTP 21
  • Other functionality

Thoughts? I see you are maintaining a fork, and I think if we do the commits in the above order the git histories will be reconcilable by merge cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants