Update Erlang Deps (rebar3) by lbakerchef · Pull Request #2289 · chef/chef-server

lbakerchef · 2021-03-05T12:18:13Z

Tests

https://buildkite.com/chef/chef-chef-server-master-verify/builds/3574
https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2315
https://buildkite.com/chef/chef-umbrella-master-chef-server/builds/320
https://buildkite.com/chef/chef-chef-server-master-verify/builds/3712
https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2410
https://buildkite.com/chef/chef-umbrella-master-chef-server/builds/346#07fd3280-0fdb-4a06-aa36-52e9ec8bfe60

Related PRs

chef/chef_secrets#62
chef/sqerl#112
chef/ej#1

Current Status

After making changes discussed with @PrajaktaPurohit (see conversation below for context), there were failures on verify and adhoc pipelines. As such, four new branches were created, each reverting a particular change that was made. Each new branch was run through verify and adhoc tests:

lbaker/update-rebars-bifrost-revert-ej
https://buildkite.com/chef/chef-chef-server-master-verify/builds/3688
https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2390

lbaker/update-rebars-bifrost-revert-sqerl
https://buildkite.com/chef/chef-chef-server-master-verify/builds/3689
https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2391

lbaker/update-rebars-bifrost-revert-secrets
https://buildkite.com/chef/chef-chef-server-master-verify/builds/3690

lbaker/update-rebars-bifrost-revert-ibrowse
https://buildkite.com/chef/chef-chef-server-master-verify/builds/3691
https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2393

The branch which reverted the ibrowse changes passed verify and adhoc tests. That branch was subsequently run through umbrella. While there were some failures, an examination revealed that the same failures were also on master:

https://buildkite.com/chef/chef-umbrella-master-chef-server/builds/339
https://buildkite.com/chef/chef-umbrella-master-chef-server/builds/340

Options:

Merge the passing branch reverting ibrowse changes: lbaker/update-rebars-bifrost-revert-ibrowse
Investigate why pointing to chef/ibrowse causes failures.
Other.

Check List

All buildkite tests pass
Full omnibus build and tests in buildkite pass
All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco
PR title is a worthy inclusion in the CHANGELOG

netlify · 2021-03-05T12:18:18Z

Deploy preview for chef-server processing.

Building with commit 39910e4

https://app.netlify.com/sites/chef-server/deploys/606df4135367720007b59e94

marcparadise

Could you track down which dep is pulling in pooler from seth/pooler and see if it's something we can fix? It doesn't seem to be a top-level dep. Details inline.

src/oc_bifrost/rebar.lock

PrajaktaPurohit · 2021-03-10T14:22:10Z

should all the other erlang deps be updated at the same time, preferably?

lbakerchef · 2021-03-10T14:51:22Z

@PrajaktaPurohit Whatever you and @marcparadise think is best. The other erlang deps are requiring more, and ongoing work, so it may be a while. What are the pros/cons for doing it piecemeal vs all at once?

PrajaktaPurohit · 2021-03-10T18:10:45Z

Let us keep all of the rebar.config updates in sync.

lbakerchef · 2021-03-11T11:49:36Z

Roger that.

src/bookshelf/rebar.lock

src/oc_erchef/apps/data_collector/rebar.lock

src/oc_erchef/rebar.lock

src/bookshelf/rebar.config

lbakerchef · 2021-03-26T21:23:51Z

@PrajaktaPurohit I re-pointed references here to chef-secrets and ej back to master in anticipation of those repos being fixed-up and merged.

src/oc_bifrost/rebar.config

src/chef-mover/rebar.lock

src/oc_erchef/rebar.lock

PrajaktaPurohit · 2021-04-01T12:58:11Z

src/bookshelf/rebar.lock

  {git,"git://github.com/chef/chef_secrets.git",
-       {ref,"58373899212a23e4f37070aaa6d3a751b1281492"}},
+       {branch,"master"}},
  0},


looks like ibrowse in ➜ chef-server git:(master) ✗ ack "ibrowse.git"
src/bookshelf/rebar.lock
42: {git,"git://github.com/cmullaparthi/ibrowse.git",
points to the upstream, I think this can be changed to chef/ibrowse:chef-server branch once we figure out what brings this in.

chef/mini_s3@9899ce8 - let a create an issue to check that this has indeed been resolved.

Apparently mini_s3 uses cmullaparthi/ibrowse.
Additional investigation revealed that the upcoming sigv4 work does not appear to reference ibrowse (in mini_s3).
PROPOSED RESOLUTION: Do nothing with mini_s3. Merge of sigv4 should resolve the issue.

src/bookshelf/rebar.config

lbakerchef · 2021-04-02T05:09:11Z

Code reviewed this with @PrajaktaPurohit. Pursuant to that, I created this outline of what needs to be done.

SQERL
       A.  branch lbaker/envy standardizes usage of deps to markan/envy vs manderson26/envy.
            RESOLUTION:  don’t use this branch - make an issue to fork mark’s repo.
            https://github.com/chef/chef-server/issues/2388
       B.  there was a different branch and pr to use chef/pooler vs seth/pooler.
             this was merged already.
            RESOLUTION:  point chef-server to use sqerl/master
       C.  chef-server pins to very old commits of sqerl.
             RESOLUTION:  update the locks to point to latest sqerl master.
2.  CHEF_SECRETS
     A.  chef_secrets/lbaker/ej and PR 62 use chef/ej, not seth/ej.
           this chef_secrets PR/branch hasn’t been merged yet; there is an issue with expediter on chef_secrets repo.
           RESOLUTION:  point chef-server to chef_secrets/lbaker/ej for now; create an issue for chef_secrets expediter.
           https://github.com/chef/chef_secrets/issues/64
3.  IBROWSE
     A.  some references point to cmullaparthi.
          RESOLUTION: use chef/ibrowse (fork of cmullaparthi).  it has some fixes to some transient issues seen in the pipelines.
         create an issue to update our fork of cmullaparthi, as it is behind the upstream repo.
         [I had no authority to create this issue]
4.  EJ
     A chef/ej PR was merged with fixes for erlang19.
     RESOLUTION: Point chef-server to latest chef/ej master.
5.  MINI_S3 REPO
     Apparently mini_s3 uses cmullaparthi/ibrowse.
     Additional investigation revealed that the upcoming sigv4 work does not appear to reference ibrowse.
     PROPOSED RESOLUTION: do nothing.

src/bookshelf/rebar.config

src/bookshelf/rebar.lock

src/oc_erchef/rebar.config

src/oc_erchef/rebar.lock

src/oc_bifrost/rebar.lock

src/oc_erchef/apps/data_collector/rebar.lock

PrajaktaPurohit

Feel free to squash and merge if the latest adhoc and umbrella builds have passed.

Signed-off-by: Lincoln Baker <lbaker@chef.io>

lbakerchef self-assigned this Mar 5, 2021

lbakerchef requested review from a team as code owners March 5, 2021 12:18

marcparadise requested changes Mar 5, 2021

View reviewed changes

src/oc_bifrost/rebar.lock Outdated Show resolved Hide resolved

lbakerchef force-pushed the lbaker/update-rebars-bifrost branch 3 times, most recently from e22bcc8 to a3ae2d6 Compare March 9, 2021 17:52

marcparadise approved these changes Mar 9, 2021

View reviewed changes

tas50 changed the title ~~Update bifrost dependencies.~~ Update bifrost dependencies & other erlang deps Mar 11, 2021

lbakerchef changed the title ~~Update bifrost dependencies & other erlang deps~~ Update Erlang Deps (rebar3) Mar 15, 2021

lbakerchef force-pushed the lbaker/update-rebars-bifrost branch 6 times, most recently from e8f7e69 to 00d561b Compare March 16, 2021 18:46

PrajaktaPurohit reviewed Mar 16, 2021

View reviewed changes

src/bookshelf/rebar.lock Outdated Show resolved Hide resolved

PrajaktaPurohit reviewed Mar 16, 2021

View reviewed changes

src/bookshelf/rebar.lock Outdated Show resolved Hide resolved

PrajaktaPurohit reviewed Mar 16, 2021

View reviewed changes

src/oc_erchef/apps/data_collector/rebar.lock Outdated Show resolved Hide resolved

PrajaktaPurohit reviewed Mar 16, 2021

View reviewed changes

src/oc_erchef/rebar.lock Show resolved Hide resolved

lbakerchef force-pushed the lbaker/update-rebars-bifrost branch from 00d561b to 789c291 Compare March 16, 2021 23:57

lbakerchef mentioned this pull request Mar 23, 2021

Use chef/ej, not seth/ej chef/chef_secrets#62

Merged

7 tasks

lbakerchef force-pushed the lbaker/update-rebars-bifrost branch from 77f89ca to 8cea032 Compare March 24, 2021 06:08

lbakerchef mentioned this pull request Mar 24, 2021

Use chef/envy, not manderson26/envy chef/sqerl#112

Open

10 tasks

lbakerchef requested a review from PrajaktaPurohit March 25, 2021 04:53

PrajaktaPurohit reviewed Mar 26, 2021

View reviewed changes

src/bookshelf/rebar.config Show resolved Hide resolved

lbakerchef force-pushed the lbaker/update-rebars-bifrost branch from 8cea032 to 1264cfe Compare March 26, 2021 21:20

PrajaktaPurohit reviewed Apr 1, 2021

View reviewed changes

src/oc_bifrost/rebar.config Outdated Show resolved Hide resolved

PrajaktaPurohit reviewed Apr 1, 2021

View reviewed changes

src/chef-mover/rebar.lock Outdated Show resolved Hide resolved

PrajaktaPurohit reviewed Apr 1, 2021

View reviewed changes

src/oc_erchef/rebar.lock Outdated Show resolved Hide resolved

PrajaktaPurohit reviewed Apr 1, 2021

View reviewed changes

src/bookshelf/rebar.config Outdated Show resolved Hide resolved

lbakerchef force-pushed the lbaker/update-rebars-bifrost branch 2 times, most recently from ef7f66c to 8302cfb Compare April 2, 2021 07:06

lbakerchef requested a review from PrajaktaPurohit April 2, 2021 10:02

lbakerchef changed the title ~~Update Erlang Deps (rebar3)~~ WIP Update Erlang Deps (rebar3) Apr 5, 2021

PrajaktaPurohit reviewed Apr 5, 2021

View reviewed changes

src/oc_bifrost/rebar.lock Outdated Show resolved Hide resolved

PrajaktaPurohit reviewed Apr 5, 2021

View reviewed changes

src/oc_erchef/apps/data_collector/rebar.lock Outdated Show resolved Hide resolved

lbakerchef force-pushed the lbaker/update-rebars-bifrost branch 2 times, most recently from e860ead to 328f7a0 Compare April 7, 2021 10:13

lbakerchef requested a review from PrajaktaPurohit April 7, 2021 12:51

PrajaktaPurohit approved these changes Apr 7, 2021

View reviewed changes

lbakerchef force-pushed the lbaker/update-rebars-bifrost branch from 328f7a0 to b36993e Compare April 7, 2021 17:29

Update erlang dependencies.

39910e4

Signed-off-by: Lincoln Baker <lbaker@chef.io>

lbakerchef force-pushed the lbaker/update-rebars-bifrost branch from b36993e to 39910e4 Compare April 7, 2021 18:04

lbakerchef merged commit 457bf34 into master Apr 7, 2021

lbakerchef deleted the lbaker/update-rebars-bifrost branch April 7, 2021 18:41

lbakerchef changed the title ~~WIP Update Erlang Deps (rebar3)~~ Update Erlang Deps (rebar3) Apr 8, 2021

lbakerchef mentioned this pull request Apr 13, 2021

Pin to latest commit of sqerl master #2330

Closed

Conversation

lbakerchef commented Mar 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests

Related PRs

Current Status

Check List

Uh oh!

netlify bot commented Mar 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcparadise left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PrajaktaPurohit commented Mar 10, 2021

Uh oh!

lbakerchef commented Mar 10, 2021

Uh oh!

PrajaktaPurohit commented Mar 10, 2021

Uh oh!

lbakerchef commented Mar 11, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lbakerchef commented Mar 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PrajaktaPurohit Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

PrajaktaPurohit Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

lbakerchef Apr 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lbakerchef commented Apr 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PrajaktaPurohit left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lbakerchef commented Mar 5, 2021 •

edited

Loading

netlify bot commented Mar 5, 2021 •

edited

Loading

lbakerchef Apr 5, 2021 •

edited

Loading

lbakerchef commented Apr 2, 2021 •

edited

Loading