Implement randomBytes for emscripten#99
Open
chirag-parmar wants to merge 2 commits intocheatfate:masterfrom
Open
Implement randomBytes for emscripten#99chirag-parmar wants to merge 2 commits intocheatfate:masterfrom
randomBytes for emscripten#99chirag-parmar wants to merge 2 commits intocheatfate:masterfrom
Conversation
chirag-parmar
force-pushed
the
emscripten
branch
from
99c6c68 to
a1316a3
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements
randomBytesforemscripten. According to the rust crategetrandomand the PR linked on the same page emscripten-core/emscripten#12240emscriptenwrapsgetRandomDevice(browser version of obtaining randomness) within thegetentropyfunction.Changes
randomBytesforemscriptenrandomBytesofopenbsdwithemscripten. Before this PR,randomByteswithin theopenbsdsegment did not care for the maximum chunk size allowed bygetentropy(1, 2). This would resulted in using/dev/urandomfor randomness above 256 bytes.urandomReadto accomodate foremscriptensince users might not defineposixflag withemscripten.