Skip to content

Add version annotation to APIService to prevent race conditions during rolling upgrades #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdzhigarov wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add version annotation to APIService to prevent race conditions during rolling upgrades #1813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/config/agg-api.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ apiVersion: apiregistration.k8s.io/v1
kind: APIService
metadata:
name: v1alpha1.data.packaging.carvel.dev
annotations:
kapp-controller.carvel.dev/version: v0.0.0
spec:
group: data.packaging.carvel.dev
groupPriorityMinimum: 100
Expand Down
3 changes: 3 additions & 0 deletions hack/build-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ export version="$(get_kappctrl_ver)"
sed 's/v0.0.0/'"$version"'/' config/config/deployment.yml > tmp/deployment.yml
mv tmp/deployment.yml config/config/deployment.yml

sed 's/v0.0.0/'"$version"'/' config/config/agg-api.yml > tmp/agg-api.yml
mv tmp/agg-api.yml config/config/agg-api.yml

ytt -f config/config -f config/values-schema.yml -f config-release -v dev.version="$version" --data-values-env=KCTRL | kbld --imgpkg-lock-output .imgpkg/images.yml -f- > ./tmp/release.yml

# Update image url in kapp-controller package overlays
Expand Down
Loading