Add missing MIME type for OCaml syntax highlighting#1604
Open
tmchow wants to merge 1 commit intocarbon-app:mainfrom
Open
Add missing MIME type for OCaml syntax highlighting#1604tmchow wants to merge 1 commit intocarbon-app:mainfrom
tmchow wants to merge 1 commit intocarbon-app:mainfrom
Conversation
The OCaml entry was missing `mime: 'text/x-ocaml'`, so CodeMirror used the base mllike mode without OCaml-specific keywords. F# already had its mime field set correctly. Fixes carbon-app#1565
|
@tmchow is attempting to deploy a commit to the Carbon Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OCaml entry in
lib/constants.jswas missingmime: 'text/x-ocaml', so CodeMirror loaded the basemllikemode without OCaml-specific keywords likematch,module,try,begin, etc.F# already had its mime field (
text/x-fsharp) set correctly. This adds the same for OCaml.Fixes #1565 (old issue, but wanted to throw my hat into the ring to contribute a fix)