feat: [#241] Add canvas adapter pattern for pluggable rendering support (vol.2) by RAprogramm · Pull Request #2069 · capricorn86/happy-dom

RAprogramm · 2026-02-20T01:31:59Z

the part 2 of this accidentally closed PR

Message from previous PR
#2043 (review)

Closes #241

…kage (capricorn86#2037)

…ering support Adds ICanvasAdapter interface and static setCanvasAdapter() method to HTMLCanvasElement, allowing users to plug in real canvas implementations like node-canvas. Changes: - Add ICanvasAdapter interface with getContext(), toDataURL(), toBlob() methods - Add HTMLCanvasElement.setCanvasAdapter() and getCanvasAdapter() static methods - Delegate canvas operations to adapter when set - Add NodeCanvasAdapter implementation using node-canvas library - Add comprehensive tests (44 new tests) This enables real canvas rendering in Happy-DOM when node-canvas is installed: ```typescript import { HTMLCanvasElement } from 'happy-dom'; import { NodeCanvasAdapter } from 'happy-dom/lib/nodes/html-canvas-element/adapters/NodeCanvasAdapter.js'; HTMLCanvasElement.setCanvasAdapter(new NodeCanvasAdapter()); // Now canvas.getContext('2d') returns real CanvasRenderingContext2D ``` Closes capricorn86#241

- Fix member ordering in HTMLCanvasElement class - Add curly braces to all if statements - Add public access modifiers to methods - Add JSDoc comments for all parameters - Use angle bracket type assertions in tests - Fix code formatting per project standards

…ning incorrect values (capricorn86#1953) - Fixed focusNode getter to return the correct focus boundary point based on selection direction - Fixed focusOffset getter to return the correct focus offset based on selection direction

…s in Selection API (capricorn86#1954)

…f EcmaScript modules (capricorn86#2050) * feat: [capricorn86#2049] Adds support for caching the compiled code of EcmaScript modules * feat: [capricorn86#2049] Adds support for caching the compiled code of EcmaScript modules * feat: [capricorn86#2049] Adds support for caching the compiled code of EcmaScript modules

…t pattern (capricorn86#2056)

… according to spec (capricorn86#1960) * fix: [capricorn86#1955] Conforming stepUp and stepDown on HTMLInputElement to spec for number inputs * chore: [capricorn86#1960] Fixes implementation to follow the spec and the project coding style * chore: [capricorn86#1960] Fixes implementation to follow the spec and the project coding style ---------

…coding (capricorn86#2016) - Replace decodeHTMLAttributeValue with entities.decodeHTMLAttribute - Replace decodeHTMLEntities with entities.decodeHTML - Replace decodeXMLAttributeValue with entities.decodeXML - Replace decodeXMLEntities with entities.decodeXML - Replace encodeTextContent with entities.escapeText - Add entities@6 as dependency - Remove unused regex patterns and lookup tables - Add test for numeric character reference decoding in attributes This fixes issue capricorn86#1947 where numeric character references like &capricorn86#34; and " were not being decoded in HTML attribute values.

… character references in attr values (capricorn86#1948) - attribute values can contain named and numeric character references per https://html.spec.whatwg.org/multipage/syntax.html#syntax-attribute-value - add decoding for all numeric character references - add decoding for ', this could probably appear in single-quoted attribute values - ignore other named character references, the list is huge

* fix: Node.replaceWith does not throw w/o parent ```js let div = document.createElement("div"); let span = document.createElement("span"); div.parentNode; // null span.parentNode; // null div.replaceWith(span); // ok ``` * chore: remove unused DOMException import * chore: [#0] Adds unit test ---------

…6#2027) * fix: [capricorn86#1959] Implement Text.wholeText property * fix: [capricorn86#1959] Implement Text.wholeText property ---------

…w flow content (capricorn86#2058) Fixes capricorn86#2052 ## Problem The caption element was incorrectly configured with contentModel: textOrComments, which only allowed text nodes and comments. Per the HTML spec, caption elements should contain flow content (inline and block elements), except table elements. This caused elements like <b>, <em>, <span>, etc. to be incorrectly moved outside the caption during parsing. ## Changes ### packages/happy-dom/src/config/HTMLElementConfig.ts Updated caption element configuration to match the HTML spec and follow the same pattern as td/th elements: - Changed contentModel from textOrComments to noForbiddenFirstLevelDescendants - Added forbiddenDescendants: table structure elements (table, tbody, thead, tfoot, tr, td, th, col, colgroup) - Added permittedParents: ['table'] to ensure caption only appears in tables ### packages/happy-dom/test/html-parser/HTMLParser.malformedHTML.test.ts Added comprehensive test coverage for caption element content model: - Inline elements preservation (b, strong, em, span, a) - Nested inline elements - Block-level elements (p, div) - Table element prohibition - Content serialization - permittedParents validation (wrong parent, standalone, correct parent) ## Implementation Details This fix follows the same pattern as PR capricorn86#2007 for paragraph elements, using the existing noForbiddenFirstLevelDescendants content model. While this doesn't recursively check deeply nested table elements, it matches the existing codebase patterns and handles the vast majority of real-world cases.

…l-registrator (capricorn86#2061)

…SS spec (capricorn86#2062) * fix: [capricorn86#2057] Support Unicode characters in selectors per CSS spec The CSS specification allows identifiers (class names, IDs, element names) to contain ISO 10646 characters U+00A0 and higher. The regex patterns in SelectorParser.ts were only allowing ASCII characters plus a hardcoded workaround for guillemets. This change updates both SELECTOR_REGEXP and SIMPLE_SELECTOR_REGEXP to accept characters in the range \u00A0-\uFFFF, which covers Greek letters, CJK characters, Cyrillic, Arabic, Hebrew, and other Unicode scripts. * chore: [capricorn86#2057] Adds unit tests * chore: [capricorn86#2057] Adds unit tests ---------

…ricorn86#2059) * fix: [capricorn86#2042] Support CSS gradients with rgba() colors This fix resolves an issue where CSS background properties containing linear gradients with rgba() color values would return empty strings. Root Cause: - GRADIENT_REGEXP pattern used [^)]+ which stopped at the first closing parenthesis, failing to match gradients with nested rgba() functions - String splitting logic didn't respect nested parentheses, incorrectly splitting rgba(0, 0, 0, 0) into multiple invalid parts Solution: - Updated GRADIENT_REGEXP to handle one level of nested parentheses - Improved getGradient() to split commas while respecting parentheses depth - Added splitByComma() and splitBySpace() helper functions to properly handle nested parentheses when parsing CSS values - Updated getBackground() and getBackgroundImage() to use new helpers Tests: - Added 15 comprehensive test cases covering rgba(), hsla(), rgb(), hsl() - Tests include repeating gradients, conic gradients, multiple gradients - Tests verify edge cases: many color stops, decimal values, whitespace - All 7,184 tests pass chore: [capricorn86#2042] Format test file * fix: [capricorn86#2042] Improves performance on splitting * fix: [capricorn86#2042] Improves performance on splitting * fix: [capricorn86#2042] Improves performance on splitting ---------

…ssing export for vue and vue-compat v3.5 (capricorn86#2067)

…or with has expression (capricorn86#2068) * fix: [capricorn86#1910] Fixes issue when parsing complex CSS has expression * fix: [capricorn86#1910] Fixes issue when parsing complex CSS has expression * fix: [capricorn86#1910] Fixes issue when parsing complex CSS has expression

…dapter - Add 13 comprehensive tests for CanvasAdapter - Add .gitignore and .npmignore files - Enhance README.md with usage examples and API documentation - Update package.json with scripts, keywords and complete metadata - Update tsconfig.json with additional compiler options - Add canvas documentation to happy-dom README

Canvas

…ering support

RAprogramm · 2026-02-20T01:56:25Z

@capricorn86, CI is failing because of tests in @happy-dom/node-canvas-adapter — it requires the native canvas library, which isn't available in the CI environment.

Since the canvas adapter is an optional dependency, what's the best approach:

Skip these tests in CI?
Add canvas dependencies installation to the workflow?
Use mocks for tests in CI?

Could you advise on the right way to handle this?

Thanks!

capricorn86 · 2026-02-20T23:23:47Z

@capricorn86, CI is failing because of tests in @happy-dom/node-canvas-adapter — it requires the native canvas library, which isn't available in the CI environment.

Since the canvas adapter is an optional dependency, what's the best approach:

Skip these tests in CI?

Add canvas dependencies installation to the workflow?

Use mocks for tests in CI?

Could you advise on the right way to handle this?

Thanks!

@RAprogramm It looks really good! I will soon look into this more closely and see if something is missing, but I don't think so.

I think that the library can be added as dev dependency (in addition to be an optional dependency). It should solve the problem as it will only be available in the dev environment and not in the published package.

capricorn86 · 2026-03-12T23:12:03Z

Update: I've been working on adding types and make sure that functions such as drawImage() will work with various types.

capricorn86 and others added 26 commits January 23, 2026 01:19

fix: [capricorn86#2035] Updates README.md for the server-renderer pac…

c225b09

…kage (capricorn86#2037)

fix: [capricorn86#1952] Accept Document nodes as valid boundary point…

93c10fd

…s in Selection API (capricorn86#1954)

Merge branch 'master' into master

a760641

feat: [capricorn86#2055] Changes internal types to follow a consisten…

80b4acb

…t pattern (capricorn86#2056)

fix: [capricorn86#1959] Implement Text.wholeText property (capricorn8…

a7d2885

…6#2027) * fix: [capricorn86#1959] Implement Text.wholeText property * fix: [capricorn86#1959] Implement Text.wholeText property ---------

feat: [capricorn86#2060] Adds support for register on import in globa…

02ccea8

…l-registrator (capricorn86#2061)

fix: [capricorn86#2066] Update entities package version to resolve mi…

4789145

…ssing export for vue and vue-compat v3.5 (capricorn86#2067)

feat: [capricorn86#241] Refactor canvas adapter to use browser settings

815d149

feat: [capricorn86#241] Fix index.ts missing import

28b944a

Merge upstream/master into canvas - resolve conflicts

d1c8643

Merge upstream/master into canvas

9a358c8

feat: [capricorn86#241] Update package-json.lock

4e2f47d

Merge pull request #4 from RAprogramm/canvas

20549b9

Canvas

RAprogramm requested a review from capricorn86 as a code owner February 20, 2026 01:32

RAprogramm added 2 commits February 20, 2026 08:45

feat: [capricorn86#241] Add canvas adapter pattern for pluggable rend…

d63c2cc

…ering support

feat: [capricorn86#241] Canvas. Fix imports and callback sig

02e2a52

RAprogramm and others added 3 commits February 22, 2026 08:37

Merge branch 'master' into master

683c24e

feat: [capricorn86#241] Skip canvas tests if canvas not exists

8b956dd

feat: [capricorn86#241] Add missing field to mocks

a4268e4

RAprogramm and others added 9 commits April 8, 2026 18:34

Merge branch 'capricorn86:master' into master

215fb88

chore: [#0] Continues on implementation

87f7e41

Merge branch 'master' of https://github.com/RAprogramm/fork-happy-dom

b5a11a7

Merge branch 'capricorn86:master' into master

821c8de

chore: [#0] Continues on implementation

f236c29

Merge branch 'master' of https://github.com/RAprogramm/fork-happy-dom

900bd4f

chore: [#0] Continues on implementation

dbde116

chore: [#0] Continues on implementation

5fc4139

chore: [#0] Continues on implementation

e40ca47

coderabbitai Bot mentioned this pull request Apr 29, 2026

test(load3d): add unit tests for AnimationManager, CameraManager, RecordingManager, and load3dService Comfy-Org/ComfyUI_frontend#11733

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: [#241] Add canvas adapter pattern for pluggable rendering support (vol.2)#2069

feat: [#241] Add canvas adapter pattern for pluggable rendering support (vol.2)#2069
RAprogramm wants to merge 40 commits intocapricorn86:masterfrom
RAprogramm:master

RAprogramm commented Feb 20, 2026 •

edited

Loading

Uh oh!

RAprogramm commented Feb 20, 2026 •

edited

Loading

Uh oh!

capricorn86 commented Feb 20, 2026 •

edited

Loading

Uh oh!

capricorn86 commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

RAprogramm commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RAprogramm commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

capricorn86 commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

capricorn86 commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

RAprogramm commented Feb 20, 2026 •

edited

Loading

RAprogramm commented Feb 20, 2026 •

edited

Loading

capricorn86 commented Feb 20, 2026 •

edited

Loading