Skip to content

chore: [#deps] Upgrade whatwg-mimetype to v5.0.0#2044

Open
TrevorBurnham wants to merge 1 commit intocapricorn86:masterfrom
TrevorBurnham:upgrade-whatwg-mimetype-5
Open

chore: [#deps] Upgrade whatwg-mimetype to v5.0.0#2044
TrevorBurnham wants to merge 1 commit intocapricorn86:masterfrom
TrevorBurnham:upgrade-whatwg-mimetype-5

Conversation

@TrevorBurnham
Copy link
Copy Markdown
Contributor

@TrevorBurnham TrevorBurnham commented Jan 24, 2026

This PR upgrades whatwg-mimetype from v3 to v5. This is a routine dependency upgrade that should have no impact on behavior. The new package version is more modern and includes the TypeScript types, removing the need for the separate @types/whatwg-mimetype dep.

@ocavue
Copy link
Copy Markdown
Contributor

ocavue commented Feb 15, 2026

In your PR description:

The new package version is more modern and includes the TypeScript types, removing the need for the separate @types/whatwg-mimetype dep.

But in your code:

// @ts-expect-error whatwg-mimetype v5 has no TypeScript declarations
import WhatwgMIMEType from 'whatwg-mimetype/lib/mime-type.js';

It seems that one of them is incorrect.

@TrevorBurnham
Copy link
Copy Markdown
Contributor Author

🤦‍♂️ Sorry about that! I see that there's a pending PR to update the @types/whatwg-mimetype package for v5: DefinitelyTyped/DefinitelyTyped#74483 I'll update this PR to use those types once they're merged in.

@TrevorBurnham TrevorBurnham force-pushed the upgrade-whatwg-mimetype-5 branch from b82388c to 9a84ed4 Compare February 28, 2026 18:46
@TrevorBurnham TrevorBurnham force-pushed the upgrade-whatwg-mimetype-5 branch from 9a84ed4 to b7cdec8 Compare February 28, 2026 18:53
@TrevorBurnham
Copy link
Copy Markdown
Contributor Author

I've updated this PR to use both whatwg-mimetype@5.0.0 and the newly-minted @types/whatwg-mimetype@5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants