Update workflow config#438
Conversation
There was a problem hiding this comment.
The PR makes good progress on supply-chain hardening (pinned SHAs, Harden Runner, Dependabot, and moving CF credentials to env vars), but there are three issues to address: a leaked inputs.* expression in a debug log that undermines the env-var refactoring, an implicit credential passing in cf auth that relies on undocumented env-var behavior, and one missed actions/checkout@v5 mutable tag in the integration-tests job that was left unpinned while every other occurrence was correctly updated.
PR Bot Information
Version: 1.20.37
- Correlation ID:
04011065-d94b-4907-9d5e-67027b3cded5 - Event Trigger:
pull_request.opened - LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
| done | ||
|
|
||
| - uses: actions/checkout@v5 | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 |
There was a problem hiding this comment.
This checkout is maybe redundant since the test.yml workflow already checkouts before calling the action. See cap-js/ai
|
Lets wait with this until synced with Simon. Dont have access to settings here, so cant merge anyway |
There was a problem hiding this comment.
we should check whether we need to target the main branch here. I saw in @eric-pSAP #376 the tests are failing and somehow here they are not.
|
Will be superseeded by another PR |
Harden CI Workflows and Pin Action Versions
Chore
🔧 Updated all GitHub Actions workflows to use pinned action versions (by commit SHA) and added
step-security/harden-runnerto improve supply chain security. A Dependabot configuration has also been introduced to automate weekly dependency updates for both npm and GitHub Actions.Changes
.github/dependabot.yml: Added Dependabot configuration to automate weekly updates for npm packages and GitHub Actions, with a 7-day cooldown..github/actions/integration-tests/action.yml: Pinnedactions/checkoutto commit SHA (v4) andactions/setup-nodeto commit SHA (v4). Refactored CF login to use separatecf api,cf auth, andcf targetcommands with environment variables instead of inline secrets incf login..github/workflows/check-changelog.yml: Addedharden-runnerstep and pinnedtarides/changelog-check-actionto commit SHA (v3)..github/workflows/issue.yml: Addedharden-runnerstep and pinnedactions/github-scriptto commit SHA (v8)..github/workflows/lint.yml: Addedharden-runnerstep to bothlintandprettierjobs; pinnedactions/checkoutandactions/setup-nodeto commit SHAs (v4)..github/workflows/prevent-issue-labeling.yml: Addedharden-runnerstep..github/workflows/release.yml: Addedharden-runnerstep; pinnedactions/checkout,actions/setup-node,schwma/parse-changelog-action, andncipollo/release-actionto commit SHAs..github/workflows/test.yml: Addedharden-runnerstep to all jobs; pinnedactions/checkoutandactions/setup-nodeto commit SHAs (v4) across unit test, integration test, and Postgres test jobs.PR Bot Information
Version:
1.20.37anthropic--claude-4.6-sonnet04011065-d94b-4907-9d5e-67027b3cded5pull_request.opened