Draft
Conversation
ggreif
commented
Apr 12, 2026
| fmodf \ | ||
| log | ||
|
|
||
| EXPORTED_SYMBOLS_64=\ |
Contributor
Author
There was a problem hiding this comment.
This is dead code. None of our RTS libraries export it.
Contributor
ggreif
force-pushed
the
gabor/nixpkgs-canary
branch
from
f1788b7 to
9f6c398
Compare
\`wasm-ld\` shipped with clang 20 drops the empty \`__wasm_apply_data_relocs\` function (no relocations apply for this test) and folds \`link_start.1\` (the wrapper that called \`__wasm_apply_data_relocs\` then \`link_start\`) into a direct \`(start \$link_start)\`. Output is functionally equivalent. Diff applied verbatim from CI run 24940122512. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linker
wasm-ldhas changed. It is necessary to check whether the now missing export is in any way a problem.Wait till we are on
nixpkgs-26.05.After this bump I don't expect problems with moving to
clang-21. Then thenixclosure will only contain a singleclang!