Skip to content

caddyhttp: prefer port 443 in auto-HTTPS and add tests - #7666

Merged
steadytao merged 1 commit into
masterfrom
fix-4529
Apr 23, 2026
Merged

caddyhttp: prefer port 443 in auto-HTTPS and add tests#7666
steadytao merged 1 commit into
masterfrom
fix-4529

Conversation

@mholt

@mholt mholt commented Apr 22, 2026

Copy link
Copy Markdown
Member

This hopefully fixes #4529 without breaking the fix in #6226.

Assistance Disclosure

At the behest of @francislavoie I am trying Copilot in VS Code 😄

Feels weird to propose a change I did not write myself.

I do like that it writes tests though. I hate writing tests 😆

@mholt mholt added this to the v2.11.3 milestone Apr 22, 2026
@mholt mholt added the bug 🐞 Something isn't working label Apr 22, 2026

@steadytao steadytao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my goodness, you'll have to change the status now Matt.

Just kidding, patch LGTM.

I forgot to mention I tested 6226's case locally, its just fine, whoops

@steadytao
steadytao merged commit 441d5eb into master Apr 23, 2026
31 checks passed
@steadytao
steadytao deleted the fix-4529 branch April 23, 2026 07:29
@mholt

mholt commented Apr 23, 2026

Copy link
Copy Markdown
Member Author

Thanks for testing the other one @steadytao

And hey, I will always write code by my bare hands. Gotta get some experience with this tech though so I'm not out of the loop like I am with Docker/k8s!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🐞 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto HTTPS redirects to the wrong entry

2 participants