Security: Path traversal risk in file-reading helper methods#2916
Open
tuanaiseo wants to merge 1 commit intoc3js:masterfrom
Open
Security: Path traversal risk in file-reading helper methods#2916tuanaiseo wants to merge 1 commit intoc3js:masterfrom
tuanaiseo wants to merge 1 commit intoc3js:masterfrom
Conversation
Helper methods build file paths by string concatenation (e.g., `open("docs/js/samples/" + id + ".js")`) without sanitizing `id`/`name`. If these values can be influenced externally, attackers may read unintended files via traversal sequences.
Affected files: config.rb
Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Helper methods build file paths by string concatenation (e.g.,
open("docs/js/samples/" + id + ".js")) without sanitizingid/name. If these values can be influenced externally, attackers may read unintended files via traversal sequences.Severity:
mediumFile:
config.rbSolution
Validate inputs against strict allowlists (expected sample names), normalize paths, and enforce that resolved paths remain within intended directories before opening files.
Changes
config.rb(modified)Testing