Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/browser_harness/run.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import os, sys, time, urllib.request
import json, os, sys, time, urllib.request
from io import StringIO

# Windows default stdout/stderr encoding is cp1252
Expand Down Expand Up @@ -70,9 +70,12 @@
def _local_chrome_listening():
for port in (9222, 9223):
try:
urllib.request.urlopen(f"http://127.0.0.1:{port}/json/version", timeout=0.3).close()
return True
except OSError: pass
with urllib.request.urlopen(f"http://127.0.0.1:{port}/json/version", timeout=0.3) as response:
version = json.loads(response.read())
if isinstance(version, dict) and isinstance(version.get("webSocketDebuggerUrl"), str) and version["webSocketDebuggerUrl"]:
return True
except (OSError, TypeError, ValueError):
pass
return False


Expand Down
19 changes: 15 additions & 4 deletions tests/unit/test_run.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import sys
from io import StringIO
from unittest.mock import patch
from unittest.mock import MagicMock, patch

import pytest

Expand Down Expand Up @@ -228,12 +228,23 @@ def test_explicit_cdp_configured_helper_falsy(monkeypatch):

def test_local_chrome_listening_rejects_non_chrome():
"""A bare TCP listener on 9222/9223 must not fool the probe — only a real
/json/version response counts as Chrome."""
/json/version response with a DevTools WebSocket counts as Chrome."""
with patch("browser_harness.run.urllib.request.urlopen", side_effect=OSError):
assert run._local_chrome_listening() is False
with patch("browser_harness.run.urllib.request.urlopen") as mock_open:
for payload in (b"not JSON", b"{}", b"[]", b'{"webSocketDebuggerUrl": ""}', b'{"webSocketDebuggerUrl": 1}'):
response = MagicMock()
response.__enter__.return_value.read.return_value = payload
with patch("browser_harness.run.urllib.request.urlopen", return_value=response) as mock_open:
assert run._local_chrome_listening() is False
assert mock_open.call_count == 2


def test_local_chrome_listening_accepts_devtools_response():
response = MagicMock()
response.__enter__.return_value.read.return_value = b'{"webSocketDebuggerUrl": "ws://127.0.0.1:9222/devtools/browser/x"}'
with patch("browser_harness.run.urllib.request.urlopen", return_value=response) as mock_open:
assert run._local_chrome_listening() is True
mock_open.assert_called_once()
mock_open.assert_called_once()


def test_cli_doctor_fix_snap_invokes_guide():
Expand Down