fix: ignore type errors in copied files without mutants#523
Draft
skyswordw wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
type_check_commandcrash when a type checker reports an error in a copied file that contains no generated mutmut mutant functions.The type-check filtering step still raises for unowned errors in files that do contain generated mutants, because those remain ambiguous and may indicate a mutation affected code outside the mutant function body.
Closes #522.
Testing
uv run pytest tests/test_type_checking.pyuv run pytest tests/test_type_checking.py tests/e2e/test_e2e_type_checking.pyuv run ruff check .uv run ruff format --check .uv run pytest -k 'not test_setproctitle_crashes_after_fork_with_corefoundation_loaded'->299 passed, 2 skipped, 1 deselectedNotes:
uv run pytestreported299 passed, 2 skipped, 1 failed; the failure was the existing macOS sentineltests/utils/test_safe_setproctitle.py::test_setproctitle_crashes_after_fork_with_corefoundation_loaded, unrelated to type-check filtering.uv run pre-commit run --all-fileswas attempted but hung during hook environment bootstrap ingit submodule update --init --recursive --depth=1, before running project checks.