Skip to content

[JUDGES] Add httpbin.com.br#194

Open
dannyeuu wants to merge 3 commits intobluet:masterfrom
dannyeuu:dl-add-httpbin-com-br-judge
Open

[JUDGES] Add httpbin.com.br#194
dannyeuu wants to merge 3 commits intobluet:masterfrom
dannyeuu:dl-add-httpbin-com-br-judge

Conversation

@dannyeuu
Copy link
Copy Markdown

@dannyeuu dannyeuu commented Apr 7, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Added additional proxy judge endpoints to improve validation reliability and coverage.
    • Preserved existing judge handling, timeout, and SSL verification behavior to maintain compatibility.
    • No public API or signature changes were introduced.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5af14cee-8bda-473a-995c-232d03ccfd1a

📥 Commits

Reviewing files that changed from the base of the PR and between b6a1b1d and 8d520d7.

📒 Files selected for processing (1)
  • proxybroker/judge.py
✅ Files skipped from review due to trivial changes (1)
  • proxybroker/judge.py

Walkthrough

The default judges list in get_judges (proxybroker/judge.py) was expanded to include two additional endpoints: http://httpbin.com.br/anything?show_env and https://http://httpbin.com.br/anything?show_env. No other logic or signatures were changed.

Changes

Cohort / File(s) Summary
Judge endpoints expansion
proxybroker/judge.py
Added two new judge URLs to get_judges default list: http://httpbin.com.br/anything?show_env and https://http://httpbin.com.br/anything?show_env. All other get_judges behavior (wrapping non-Judge inputs, applying timeout/verify_ssl) remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I hopped a route across the net,
Two new judges lined my alphabet,
One plain HTTP, one odd in scheme,
I sniff their headers, chase the stream,
A tiny hop to learn and vet.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[JUDGES] Add httpbin.com.br' clearly and specifically indicates the main change: adding a new judge endpoint from httpbin.com.br to the judges list.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two new judge URLs from httpbin.com.br to the proxy checker list. Feedback suggests appending the ?show_env parameter to these URLs to ensure that environment headers are returned, which is necessary for accurately determining the anonymity level of proxies.

Comment thread proxybroker/judge.py Outdated
dannyeuu and others added 2 commits April 8, 2026 17:21
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant