Skip to content

Update plan curtailment modal form layout#247

Merged
negarn merged 7 commits into
mainfrom
negar/gh-242-update-plan-curtailment-modal-form-layout
May 19, 2026
Merged

Update plan curtailment modal form layout#247
negarn merged 7 commits into
mainfrom
negar/gh-242-update-plan-curtailment-modal-form-layout

Conversation

@negarn

@negarn negarn commented May 15, 2026

Copy link
Copy Markdown
Contributor

🤖

Summary

  • Rework the plan curtailment modal into response profile, reason, curtail behavior, restore behavior, and target sections while preserving the existing input/control sizing.
  • Constrain curtailment behavior to the API-supported values: fixed kW reduction and least efficient first.
  • Remove unsupported percentage reduction, alternate miner selection strategies, curtail batch controls, and the Safety section from the form.
  • Keep the preview copy aligned with the existing estimated reduction vs requested reduction behavior.
  • Default maintenance-mode miner inclusion to checked, remove its helper line, and require confirmation before submitting with maintenance miners included.
  • Update modal tests and stories for the supported layout and payload behavior.

Test plan

  • git diff --check
  • bin/npx prettier --check src/protoFleet/features/energy/CurtailmentStartModal.tsx src/protoFleet/features/energy/CurtailmentStartModal.test.tsx src/protoFleet/features/energy/CurtailmentStartModal.stories.tsx
  • bin/npx vitest run src/protoFleet/features/energy/CurtailmentStartModal.test.tsx
  • bin/npx eslint src/protoFleet/features/energy/CurtailmentStartModal.tsx src/protoFleet/features/energy/CurtailmentStartModal.test.tsx src/protoFleet/features/energy/CurtailmentStartModal.stories.tsx --max-warnings 0
  • bin/npx tsc --noEmit
  • bin/npm run build:protoFleet
  • PR CI passed after rerunning the transient generated-code check
Screen.Recording.2026-05-19.at.8.45.35.AM.mov

Closes #242

@github-actions github-actions Bot added javascript Pull requests that update javascript code client labels May 15, 2026
@github-actions

This comment has been minimized.

@negarn
negarn marked this pull request as ready for review May 15, 2026 17:36
@negarn
negarn requested a review from a team as a code owner May 15, 2026 17:36
Copilot AI review requested due to automatic review settings May 15, 2026 17:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26542f48da

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread client/src/protoFleet/features/energy/CurtailmentStartModal.tsx Outdated
Comment thread client/src/protoFleet/features/energy/CurtailmentStartModal.tsx Outdated

This comment was marked as resolved.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3b7f5eafd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread client/src/protoFleet/features/energy/CurtailmentStartModal.tsx
@negarn
negarn merged commit b027e73 into main May 19, 2026
68 checks passed
@negarn
negarn deleted the negar/gh-242-update-plan-curtailment-modal-form-layout branch May 19, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update plan curtailment modal form layout

3 participants