Skip to content

Register the gnps backend via _proxies so the PROXI aggregator querie… - #89

Draft
rukubrakov wants to merge 1 commit into
mainfrom
fix/proxi-aggregator-backends
Draft

Register the gnps backend via _proxies so the PROXI aggregator querie…#89
rukubrakov wants to merge 1 commit into
mainfrom
fix/proxi-aggregator-backends

Conversation

@rukubrakov

Copy link
Copy Markdown
Contributor

…s GNPS alongside its default backends instead of only GNPS, and add a test asserting all backends are registered

…s GNPS alongside its default backends instead of only GNPS, and add a test asserting all backends are registered
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4b5891eb-3fce-4fa8-99b4-139a5e06c0d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🚀 Performance Benchmark Results (Python 3.11)

Comparing PR branch vs main branch

Benchmark PR (ms) Main (ms) Δ (ms) Change % Rounds Status
test_spectrum_creation_regular 0.040 0.038 +0.001 +3.3% 50
test_spectrum_creation_jit 0.032 0.032 +0.001 +1.7% 50
test_spectrum_creation_large_regular 0.193 0.191 +0.002 +0.9% 50
test_spectrum_creation_large_jit 0.185 0.183 +0.002 +1.3% 50
test_spectrum_round_regular 0.058 0.050 +0.008 +15.4% 5 ⚠️ 15.4% slower
test_spectrum_round_jit 0.019 0.018 +0.000 +0.8% 34670
test_spectrum_filter_intensity_regular 0.026 0.025 +0.000 +1.8% 5
test_spectrum_filter_intensity_jit 0.021 0.021 +0.000 +0.5% 12306
test_spectrum_scale_intensity_regular 0.049 0.058 -0.009 -15.2% 5 ✅ 15.2% faster
test_spectrum_scale_intensity_jit 0.013 0.013 -0.000 -0.1% 15958
test_creation_performance_comparison[100] 0.025 0.025 +0.000 +0.8% 50
test_creation_performance_comparison[1000] 0.038 0.038 -0.000 -0.9% 50
test_creation_performance_comparison[5000] 0.103 0.103 -0.000 -0.3% 50
test_creation_performance_comparison[10000] 0.190 0.191 -0.001 -0.8% 50
test_jit_creation_performance_comparison[100] 0.019 0.019 -0.000 -0.1% 50
test_jit_creation_performance_comparison[1000] 0.031 0.031 +0.000 +0.0% 50
test_jit_creation_performance_comparison[5000] 0.097 0.097 -0.000 -0.1% 50
test_jit_creation_performance_comparison[10000] 0.183 0.183 -0.000 -0.2% 50

Summary

  • 1 improvement (>5% faster)
  • ⚠️ 1 regression (>5% slower)
  • 16 unchanged (within ±5%)

Changes smaller than ±5% are not considered significant.
Lower times are better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant