Weird numba caching issue - #20
Open
tycheyoung wants to merge 1 commit into
Open
Conversation
Member
|
Could you elaborate a bit? When exactly does the issue occur and is it related to Numba or just a general issue? |
Author
|
If we set min_mz = 101.00, max_mz = 1500.00, bin_size=0.05, the dimension needs to be 27981. When we enable numba caching, the fraction part of bin_size changes (in my system, it changes to 0.05000000074505806), resulting in 27982 dimension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the incorrect fraction part, the resulting dim can have an error (+1/-1 difference).