chore: Update rust edition to 2024 in Cargo.toml - #425
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
==========================================
- Coverage 81.79% 81.77% -0.03%
==========================================
Files 25 25
Lines 6482 6484 +2
Branches 296 296
==========================================
Hits 5302 5302
- Misses 1081 1083 +2
Partials 99 99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ValuedMammal
force-pushed
the
edition_2024
branch
from
May 26, 2026 15:10
3adf695 to
56f4acb
Compare
ValuedMammal
force-pushed
the
edition_2024
branch
from
July 7, 2026 16:10
56f4acb to
aaebb4e
Compare
This is to reduce noise related to formatting when we change the rust edition to 2024.
Removed explicit `ref` binding modifiers, as otherwise rustc complains with "cannot explicitly borrow within an implicitly borrowing pattern." Refer to https://doc.rust-lang.org/reference/patterns.html#binding-modes for details.
Removed style_edition from rustfmt.toml and ran cargo +nightly fmt.
ValuedMammal
force-pushed
the
edition_2024
branch
from
July 23, 2026 16:30
aaebb4e to
72a95f8
Compare
ValuedMammal
marked this pull request as ready for review
July 23, 2026 17:22
Contributor
Author
|
Thanks @oleonardolima |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates bdk_wallet to Rust edition 2024 and includes the related formatting changes needed to keep the codebase consistent with the new edition style. The changes are intended to be mechanical, with no functional behavior changes or API impact.
Changelog notice
Changed
Checklists
Before submitting