Fix various bugs found during codebase audit#919
Draft
Flova wants to merge 1 commit into
Draft
Conversation
- head_mover: fix sign error in path distance calculation (NaN risk), use pitch acceleration for pitch joint, fix double->int truncation of reduce_last_scanline, replace exact float comparison with epsilon - odometry: initialize IMU mounting offset transform to identity, as the tf2 default constructor leaves it uninitialized - world_model: fix inverted rotation in get_uv_from_xy and swapped sin/cos in get_xy_from_uv, remove dead falsiness guards on tuples - pathfinding: fix angle normalization that produced negative rotation costs in time_to_ball, annotate get_ball_goal as Optional and handle None in go_to_ball - misc: replace non-existent Duration.to_sec() with nanoseconds / 1e9 - animation: pass float timeout_sec to wait_for_server instead of a Duration object, which raised a TypeError when the server was not immediately available - team_data: fix docstring of team_rank_to_ball - costmap: normalize debug costmap to valid OccupancyGrid range [0, 100] instead of overflowing int8, guard against constant costmaps - ball_filter: remove unused relative estimate lookup that silently skipped the negative observation update on tf errors - team_communication: compare move_base_goal instead of a function against None, remove illusory hasattr checks on always-present proto3 fields, initialize timestamp state as Optional[TimeMsg]
e04cf08 to
2dab5d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
pixi run build