[FIX] Manifold Learning: Fix reseting of selected number of components

[janezd]

Issue

Fixes #7163 and a few deprecation warnings.

Description of changes

The original sin was that the limit on the number of components was enforced by setting the maximal value of the spin, thus changing the user's setting. I think a better approach is to let users set whatever they want and show a warning if the actual number of components (which is limited by the data) is lower.

Further considerations:

• what is the reasonable limit? I currently set it to 99, which is way too large.
• Should individual methods further restrain it? t-SNE with 10 components takes ages.

Includes

• Code changes
• Tests

[Copilot]

Pull Request Overview

This PR fixes an issue where the manifold learning widget was resetting the user's selected number of components by constraining the spin control's maximum value. The fix introduces a new approach where users can set any value (up to 99), and a warning is displayed when the actual number of components is limited by the available data attributes.

Key Changes:

• Replaced dynamic spin control maximum constraint with a fixed upper limit of 99
• Added a new act_components property that calculates the effective number of components based on data availability
• Introduced a warning message to inform users when fewer components are created than requested
• Added comprehensive test coverage for the new component limitation behavior

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File	Description
Orange/widgets/unsupervised/owmanifoldlearning.py	Implemented act_components property, removed dynamic spin maximum constraint, added warning for component mismatch, and removed deprecated callbackOnReturn parameter
Orange/widgets/unsupervised/tests/test_owmanifoldlearning.py	Added test_too_few_attributes to verify warning behavior and updated test_n_components to use controls API
i18n/si/msgs.jaml	Added Slovenian translations for the new warning message and removed obsolete translation entry

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The spin function is being called with conflicting parameters. The positional arguments 1, 10 specify minimum and maximum values, but then maximum=99 is also passed as a keyword argument. This creates ambiguity - the positional argument 10 will be overridden by maximum=99, but this is confusing.

Consider removing the positional 10 argument and only using keyword arguments for clarity:

gui.spin(
    output_box, self, "n_components", 1, label="Components:",
    controlWidth=QFontMetrics(self.font()).horizontalAdvance("0" * 10),
    alignment=Qt.AlignRight,
    callback=self.settings_changed,
    minimum=1, maximum=99)

or keeping the positional arguments and removing the keyword argument:

gui.spin(
    output_box, self, "n_components", 1, 99, label="Components:",
    controlWidth=QFontMetrics(self.font()).horizontalAdvance("0" * 10),
    alignment=Qt.AlignRight,
    callback=self.settings_changed)

[Copilot]

The calculation self.act_components * (self.act_components + 3) / 2 uses floating-point division and may result in a float value (e.g., 7.5), but the error message expects a number of neighbors which should be an integer. Consider using integer division // or explicitly converting to int:

n = self.act_components * (self.act_components + 3) // 2

Suggested change

	n = self.act_components * (self.act_components + 3) / 2
	n = self.act_components * (self.act_components + 3) // 2

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.92%. Comparing base (cd252e3) to head (a229ce0).
⚠️ Report is 119 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7191   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files         335      335           
  Lines       74191    74195    +4     
=======================================
+ Hits        65972    65981    +9     
+ Misses       8219     8214    -5     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.