Allow plugin functions in plugin_group!#24345
Open
Jengamon wants to merge 1 commit into
Open
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
4cb37a0 to
9d8b233
Compare
introduces a little idiosyncratic `fn {}` block for containing the
function members, mostly as a workaround for the fact that macro parsing
cannot backtrack
9d8b233 to
30f8623
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Allow plugin functions to be used inside
plugin_group!declarations.Right now, functions of signature
fn(&mut App)implementPlugin, but cannot be added to plugin groups, dueto how the macro is implemented.
This fixes that.
Solution
This PR fixes the problem by introducing a block after the top-level members, labeled with
fn, where the names are considered to be referencing values directly, rather than types. It looks like:Testing
I edited the doctest above the macro implementation, and made sure that passes, and the syntax is non-invasive otherwise, so overall, not much should change.