Skip to content

Fix AbortOnPanic-related doc comments#24310

Merged
alice-i-cecile merged 2 commits into
bevyengine:mainfrom
SpecificProtagonist:abortonpanic-doc
May 21, 2026
Merged

Fix AbortOnPanic-related doc comments#24310
alice-i-cecile merged 2 commits into
bevyengine:mainfrom
SpecificProtagonist:abortonpanic-doc

Conversation

@SpecificProtagonist
Copy link
Copy Markdown
Contributor

@SpecificProtagonist SpecificProtagonist commented May 15, 2026

Objective

Table::alloc_columns/Table::realloc_columns claimed to panic, but abort.

@SpecificProtagonist SpecificProtagonist added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 15, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in ECS May 15, 2026
chescock
chescock approved these changes May 17, 2026
View reviewed changes
Comment thread crates/bevy_ecs/src/storage/table/mod.rs Outdated
@SpecificProtagonist SpecificProtagonist added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 17, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 21, 2026
Merged via the queue into bevyengine:main with commit eda816c May 21, 2026
40 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in ECS May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@amtep amtep amtep approved these changes

@chescock chescock chescock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

ECS
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SpecificProtagonist @amtep @chescock @alice-i-cecile