Fix leak in js_array_buffer_constructor3#514
Closed
bptato wants to merge 1 commit into
Closed
Conversation
If alloc_flag is unset, then we are expected to consume the buffer even if we throw an exception. (At least this is what js_array_buffer_transfer seems to assume.)
bptato
commented
May 16, 2026
| @@ -56056,13 +56056,15 @@ static JSValue js_array_buffer_constructor3(JSContext *ctx, | |||
| if (!alloc_flag && buf && max_len && free_func != js_array_buffer_free) { | |||
| // not observable from JS land, only through C API misuse; | |||
| // JS code cannot create externally managed buffers directly | |||
Contributor
Author
There was a problem hiding this comment.
By the way, if this is a user error then maybe an assert would suffice?
Contributor
Author
|
Actually, there's a better way to do this. I'll open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If alloc_flag is unset, then we are expected to consume the buffer even if we throw an exception. (At least this is what js_array_buffer_transfer seems to assume.)