Skip to content

chore: upgrade packageManager to pnpm@11.9.0#343

Open
panish16 wants to merge 6 commits into
bcgov:mainfrom
panish16:feat/upgrade-pnpm-v11
Open

chore: upgrade packageManager to pnpm@11.9.0#343
panish16 wants to merge 6 commits into
bcgov:mainfrom
panish16:feat/upgrade-pnpm-v11

Conversation

@panish16

Copy link
Copy Markdown
Collaborator

Sets packageManager to pnpm@11.9.0 in web/pay-ui/package.json as part of the pnpm v11 upgrade (ticket #33875).

The CI/CD Cloud Build trigger for this app has already been updated to use pnpm@11.9.0.

@panish16 panish16 requested review from Jxio, ochiu and sumesh85 as code owners June 25, 2026 17:49
@panish16 panish16 force-pushed the feat/upgrade-pnpm-v11 branch from 2f7ee67 to b894dab Compare June 25, 2026 18:18
panish16 and others added 2 commits June 25, 2026 15:40
package.json still had packageManager pinned to pnpm@10.17.1 even
though ci.yml already requests pnpm_version: latest-11. Once the
shared frontend-ci workflow prefers packageManager over the input
(bcgov/bcregistry-sre#369), this repo would have silently kept
running on pnpm 10.17.1 instead of pnpm 11.
@panish16

Copy link
Copy Markdown
Collaborator Author

Caught something worth flagging while testing bcgov/bcregistry-sre#369 (the shared frontend-ci workflow update): package.json still had packageManager pinned to pnpm@10.17.1, even though ci.yml here already requests pnpm_version: latest-11.

Right now that doesn't matter since the current shared workflow just uses the pnpm_version input directly. But #369 changes it to prefer packageManager over the input whenever it's set (needed because pnpm/action-setup@v6 hard-errors on a conflicting explicit version). So once that merges, this repo would've kept silently running on pnpm 10.17.1 forever — CI green, but never actually exercising pnpm 11.

Pushed a fix: pinned packageManager to pnpm@11.9.0 to match ci.yml's intent. Lockfile didn't need any changes — already fully compatible, confirmed with a frozen-lockfile install. Re-tested against #369's branch and it now correctly resolves to pnpm 11.9.0 across lint/build/unit-test.

panish16 added 2 commits July 14, 2026 09:47
- version: latest-11 is a floating tag; it just moved to 11.12.0 and
  hit a pnpm/action-setup self-install bug (Cannot use 'in' operator
  to search for 'integrity' in undefined). Pinned to 11.9.0 to match
  packageManager.
- plain pnpm install fails under pnpm 11 with ERR_PNPM_IGNORED_BUILDS
  since this repo has no approved-builds config. Added --ignore-scripts
  plus an explicit nuxt prepare step, matching the shared frontend-ci
  workflow's approach. Verified locally end to end (install, prepare,
  build all exit 0).
@bolyachevets

Copy link
Copy Markdown
Collaborator

/gcbrun

1 similar comment
@panish16

Copy link
Copy Markdown
Collaborator Author

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants