feat: expose interpreter files-to-run on PyRuntimeInfo#3795
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the interpreter_files_to_run field to PyRuntimeInfo, allowing action consumers to execute an in-build runtime interpreter along with its runfiles. The changes include updates to the py_runtime rule to populate this field when an executable target is provided, validation logic to ensure consistency between the interpreter and its runfiles provider, and comprehensive tests to verify the new functionality and error handling. I have no feedback to provide.
cbf8104 to
94107d7
Compare
|
@rickeylev, @aignas - any chance of a review? |
94107d7 to
88b3b8c
Compare
88b3b8c to
9f93262
Compare
Add support for pycross_wheel_build to use PyRuntimeInfo.interpreter_files_to_run when selecting the Python executable for wheel build actions. This adds support for runtimes that expose a launcher or other executable wrapper instead of relying directly on interpreter.path. Carry the FilesToRunProvider through the pycross toolchain info as well, so configured pycross toolchains and the default Python toolchain path use the same runtime executable shape. This depends on the PyRuntimeInfo update that adds FilesToRunProvider support: bazel-contrib/rules_python#3795
9f93262 to
080e417
Compare
080e417 to
8b47e8d
Compare
rickeylev
left a comment
There was a problem hiding this comment.
Thanks for this! It's bugged me that a FilesToRun-providing target could be fed into py_runtime, but it wasn't well preserved after passing through it.
Mostly LGTM. The interpreter_files_to_run isn't being passed into PyRuntimeInfo from py_runtime. Please fix (a test to verify that would be nice, too, but not going to block on that).
For my own edification, how might the code in https://github.com/bazel-contrib/rules_python/blob/main/python/private/common.bzl#L643 (_actions_run, the if PyInterpreterProgramInfo ... code path) be updated to use this? (that some internal helper code we have for running via an action) If I'm understanding right, something like this?
exec_runtime = ctx.toolchains[EXEC_TOOLS_TOOLCHAIN_TYPE].exec_tools.exec_runtime
...
ctx.actions.run(
executable = [exec_runtime.interpreter_files_to_run],
...
)
Or it could be put into tools for a more complex case.
You are correct, except you don't need to wrap files_to_run in a list. So it will be adding the same to |
Rules that execute a py_runtime interpreter in an action need the interpreter executable together with its runfiles metadata. The existing PyRuntimeInfo fields identify the interpreter file and runtime files, but do not preserve the target's FilesToRunProvider for executable interpreter targets. Add PyRuntimeInfo.interpreter_files_to_run for runtimes created from an executable interpreter target, and validate that direct provider construction keeps the FilesToRunProvider executable aligned with the interpreter field. Direct file interpreters and platform runtimes continue to leave this field unset, preserving existing py_runtime behavior. Document the new public provider field and add focused analysis-test coverage for executable, file-only, platform, and invalid constructor cases.
8b47e8d to
2d2912d
Compare
Rules that execute a py_runtime interpreter in an action need the interpreter executable together with its runfiles metadata. The existing PyRuntimeInfo fields identify the interpreter file and runtime files, but do not preserve the target's FilesToRunProvider for executable interpreter targets.
Add PyRuntimeInfo.interpreter_files_to_run for runtimes created from an executable interpreter target, and validate that direct provider construction keeps the FilesToRunProvider executable aligned with the interpreter field. Direct file interpreters and platform runtimes continue to leave this field unset, preserving existing py_runtime behavior.
Document the new public provider field and add focused analysis-test coverage for executable, file-only, platform, and invalid constructor cases.
One example is rules_pycross wheel building with an in-build executable Python runtime. pycross needs to run the selected Python interpreter in an action, but PyRuntimeInfo previously exposed only the interpreter File and runtime files, not the interpreter target's FilesToRunProvider. For executable in-build runtimes, the FilesToRunProvider is the Bazel-native handle that carries both the executable and the runfiles metadata needed to stage it as an action tool. Exposing it lets pycross consume the runtime interpreter directly for wheel-build actions instead of reconstructing or approximating the interpreter's runtime closure from separate fields.