chore: have no-matching-distribution error message hint about target_platforms vs requirements_by_platform#3701
Merged
aignas merged 3 commits intobazel-contrib:mainfrom Apr 14, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in pkg_aliases.bzl to clarify the relationship between pip.parse.target_platforms and requirements_by_platform. The review feedback suggests refining the technical accuracy of the statement regarding host platform effects and using standard Bazel terminology by replacing 'settings' with 'attribute'.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
aignas
approved these changes
Apr 13, 2026
Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
aignas
approved these changes
Apr 13, 2026
rickeylev
added a commit
to rickeylev/rules_python
that referenced
this pull request
Apr 14, 2026
…platforms vs requirements_by_platform (bazel-contrib#3701) Based on the slack discussion where a cross-build was failing because `requirements_by_platform` was set, but `target_platforms` wasn't set, have the error message hint at the distinction to better point users for how to fix it. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com> (cherry picked from commit 6e72de2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the slack discussion where a cross-build was failing because
requirements_by_platformwas set, buttarget_platformswasn'tset, have the error message hint at the distinction to better point
users for how to fix it.