chore: factor mock mctx/rctx functionality into separate file#3700
Merged
rickeylev merged 16 commits intobazel-contrib:mainfrom Apr 13, 2026
Merged
chore: factor mock mctx/rctx functionality into separate file#3700rickeylev merged 16 commits intobazel-contrib:mainfrom
rickeylev merged 16 commits intobazel-contrib:mainfrom
Conversation
add_ag removal
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request centralizes mocking logic for Bazel repository and module contexts into a new tests/support/mocks/mocks.bzl library and refactors existing tests to use these shared utilities. Feedback identifies a bug in _mctx_new that breaks method chaining, suggests improving path resolution for MockFile objects in read methods, and recommends removing internal developer notes and fixing a logic error in _rctx_download_and_extract.
aignas
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This factors the various mocking logic spread throughout the code
base into a single mocks module. This should make it easier to re-use
and add unit tests of other functionality.