Keep tagged image pruning best effort - #1897
Open
cookesan wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes tagged-image pruning best-effort so deploys don’t get marked as failed when docker rmi refuses to remove an image (e.g., because it’s referenced by retained/stopped containers), aligning behavior with the “cleanup should not fail an otherwise successful deploy” expectation.
Changes:
- Make tagged image removal tolerant to
docker rmifailures by appending|| truein the removal loop. - Update command-string expectations in command and CLI tests to reflect best-effort pruning behavior.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/kamal/commands/prune.rb | Makes tagged-image pruning best-effort by ignoring docker rmi failures within the loop. |
| test/commands/prune_test.rb | Updates expected tagged-image prune command string to include ` |
| test/cli/prune_test.rb | Updates CLI output expectations for the images prune command to include ` |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Closes #1799
Tests
docker run --rm --platform linux/amd64 -v "$PWD:/workdir" -v kamal_bundle_cache:/usr/local/bundle -w /workdir ruby:3.4 bash -lc './bin/test test/commands/prune_test.rb test/cli/prune_test.rb'docker run --rm --platform linux/amd64 -v "$PWD:/workdir" -v kamal_bundle_cache:/usr/local/bundle -w /workdir ruby:3.4 bash -lc 'bundle exec rubocop lib/kamal/commands/prune.rb test/commands/prune_test.rb test/cli/prune_test.rb'docker rmiexits nonzero.