chore(sepolia): skip task origin validation for MAX_GAS_LIMIT upgrade#679
Merged
leopoldjoy merged 2 commits intomainfrom May 7, 2026
Merged
chore(sepolia): skip task origin validation for MAX_GAS_LIMIT upgrade#679leopoldjoy merged 2 commits intomainfrom
leopoldjoy merged 2 commits intomainfrom
Conversation
Add creator, Base facilitator, and SC facilitator signatures for the 2026-05-06-increase-max-gas-limit task.
Collaborator
✅ Heimdall Review Status
|
niran
approved these changes
May 7, 2026
0x00101010
approved these changes
May 7, 2026
danyalprout
approved these changes
May 7, 2026
Disable task origin verification (skipTaskOriginValidation: true) and remove signature files. The git init + git apply patch approach creates a non-deterministic .git directory in lib/contracts/, making tarball signatures fail on other machines.
leopoldjoy
changed the title
0x00101010
approved these changes
May 7, 2026
niran
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2026-05-06-increase-max-gas-limitby settingskipTaskOriginValidation: truein both validation filesgit init+git applypatch approach creates a non-deterministic.gitdirectory inlib/contracts/, causing tarball-based signature verification to fail across machines