Skip to content

fix(account-sdk): validate SDK config on initialization#303

Open
serdarm09 wants to merge 1 commit into
base:masterfrom
serdarm09:fix/issue-210-config-validation
Open

fix(account-sdk): validate SDK config on initialization#303
serdarm09 wants to merge 1 commit into
base:masterfrom
serdarm09:fix/issue-210-config-validation

Conversation

@serdarm09
Copy link
Copy Markdown

Closes #210

What changed:

  • Added early SDK config validation during initialization.
  • Validates appChainIds, paymasterUrls, and sub-account option values before writing config to the store.
  • Added unit tests for invalid config cases and fail-fast behavior.

How tested:

  • yarn workspace @base-org/account test src/util/validatePreferences.test.ts src/interface/builder/core/createBaseAccountSDK.test.ts --run
  • yarn workspace @base-org/account typecheck
  • yarn biome check packages/account-sdk/src/util/validatePreferences.ts packages/account-sdk/src/util/validatePreferences.test.ts packages/account-sdk/src/interface/builder/core/createBaseAccountSDK.ts packages/account-sdk/src/interface/builder/core/createBaseAccountSDK.test.ts

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented May 14, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@serdarm09 serdarm09 force-pushed the fix/issue-210-config-validation branch from e74a097 to 9de44c1 Compare May 14, 2026 09:33
@serdarm09 serdarm09 closed this May 14, 2026
@serdarm09
Copy link
Copy Markdown
Author

fix(account-sdk): validate SDK config on initialization

@serdarm09 serdarm09 reopened this May 14, 2026
@serdarm09 serdarm09 changed the title Validate SDK configuration during initialization fix(account-sdk): validate SDK config on initialization May 14, 2026
@serdarm09
Copy link
Copy Markdown
Author

Updated the commit message and PR title to conventional commit format. The commit is also verified. Ready for maintainer workflow approval and review.

@serdarm09 serdarm09 closed this May 14, 2026
@serdarm09 serdarm09 reopened this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add early validation and clear errors for missing or invalid account configuration

2 participants