Add cobol textmate language and configuration.#129
Open
kathma0905 wants to merge 2 commits intobarrettotte:masterfrom
Open
Add cobol textmate language and configuration.#129kathma0905 wants to merge 2 commits intobarrettotte:masterfrom
kathma0905 wants to merge 2 commits intobarrettotte:masterfrom
Conversation
worksofliam
requested changes
Jun 6, 2023
Collaborator
worksofliam
left a comment
worksofliam
left a comment
There was a problem hiding this comment.
Please see my comments
chrjorgensen
requested changes
Jun 6, 2023
Collaborator
There was a problem hiding this comment.
@kathma0905 Nice addition to the IBM i languages! 👍
Please provide some COBOL sources in the tests/general directory to show your grammar in action when debugging this extension - like the other source examples. The COBOL sources should ideally cover all aspects (keywords, operation codes, identifiers etc) of COBOL to validate the grammar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One IBM i language that is not covered is the COBOL language, this PR contributes COBOL language id, language configuration, and TextMate grammar.