Fix PutObject with CRT client chunkedEncodingEnabled(false)#7129
Open
davidh44 wants to merge 6 commits into
Open
Fix PutObject with CRT client chunkedEncodingEnabled(false)#7129davidh44 wants to merge 6 commits into
davidh44 wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
S3
PutObjecthangs indefinitely when usingAwsCrtAsyncHttpClientwithchunkedEncodingEnabled(false). Bug introduced in2.30.0whenrequestChecksumCalculationdefaulted toWHEN_SUPPORTED, which triggers automatic checksum computation forPutObject. With chunked encoding disabled, the SDK buffers the payload intoInMemoryPublisherto compute a header-based checksum. CRT's subscriber callsrequest(1)synchronously from withinonNext()(legal per Reactive Streams spec), causing a re-entrant deadlock inInMemoryPublisher.fulfillDemand().Modifications
Checksum computation (
http-auth-aws)FlexibleChecksummer— Replace detachedthenRunwiththenApplyto guarantee checksum headers are set before signing proceeds. Theoretical race condition fix — prevents issues if the body source delivers asynchronously.ChecksumSubscriber— Compute total buffered bytes inonComplete()and pass toInMemoryPublisher.InMemoryPublisher— Fix re-entrant deadlock infulfillDemand(): return immediately on re-entrant call instead of spinning; outerdo-whilere-checks demand after releasing for multi-threaded safety. Also implementSdkHttpContentPublisherto reportcontentLength().Signing (
sdk-core)AsyncSigningStage— PreservecontentLength()when wrappingSdkHttpContentPublisherpayload intoAsyncRequestBody, instead of always usingfromPublisher()which loses it.HTTP request construction (
sdk-core)MakeAsyncHttpRequestStage— Don't setContent-LengthifTransfer-Encodingis already present. These are mutually exclusive per RFC 7230 §3.3.2. Pre-existing latent bug exposed byInMemoryPublishernow correctly reporting content length.Testing
Added unit and integration tests
Types of changes
License