fix: declare tslib ^2.1.0 in datastore-storage-adapter and notifications (__spreadArray)

[ahmedhamouda78]

Summary

@aws-amplify/datastore-storage-adapter and @aws-amplify/notifications can fail at bundle/runtime with __spreadArray is not a function because their compiled output imports __spreadArray from tslib but neither package declares a tslib dependency — so a consumer can resolve an incompatible tslib (< 2.1). This declares tslib ^2.1.0 in both.

This is the same class of bug as #14865 (fixed for @aws-amplify/datastore in #14878). These two packages share datastore's exact profile.

Root cause

Both packages build via node ./build → tsconfig.build.json → packages/tsconfig.base.json, which sets target: es5 + downlevelIteration: true + importHelpers: true. So their emitted lib//lib-esm/ import TypeScript helpers from tslib, including tslib.__spreadArray — which only exists in tslib ≥ 2.1.0 (it is absent in tslib 1.x and 2.0.x). Neither package declares any tslib dependency, so a consumer's tree can resolve their tslib import to 1.x (e.g. pulled in by a peer such as apollo-boost), giving __spreadArray is not a function.

Example from the shipped datastore-storage-adapter (lib/common/SQLiteUtils.js):

return tslib_1.__spreadArray(tslib_1.__spreadArray([], tslib_1.__read(acc), false), ['"id" PRIMARY KEY NOT NULL'], false);

The fix

package	before	after	published tslib.__spreadArray refs
@aws-amplify/datastore-storage-adapter	(no tslib dependency)	tslib: ^2.1.0	19
@aws-amplify/notifications	(no tslib dependency)	tslib: ^2.1.0	4

^2.1.0 is the exact version that introduced __spreadArray; ^2.0.0 is insufficient because 2.0.x still lacks it. This is consistent with the rest of the monorepo (the aws-amplify meta already depends on tslib ^2.0.0).

Verification

tslib exports (runtime typeof):

tslib	__spreadArray
1.14.1	undefined
2.0.3	undefined
2.1.0 / 2.7.0 / 2.8.1	function

Published artifacts import tslib.__spreadArray: datastore-storage-adapter@2.0.70 = 19 refs, notifications@1.6.21 = 4 refs.

End-to-end (real emitted tslib_1.__spreadArray(...) shape, consumer where a peer forces tslib@1.x):

package declares	resolves tslib →	result
no tslib dep (today)	1.14.1	❌ TypeError: tslib_1.__spreadArray is not a function
tslib ^2.1.0 (this PR)	2.8.1 (own nested copy)	✅ works

Lockfile: yarn install is a no-op for yarn.lock — tslib@^2.1.0 already resolves to tslib@2.7.0 in the current lock (which has __spreadArray). In the installed workspace, both packages resolve tslib 2.7.0.

Related

• @aws-amplify/datastore potentially uses the wrong version of tslib and errors out #14865 — original @aws-amplify/datastore __spreadArray is not a function report
• fix(datastore): declare tslib ^2.1.0 to fix __spreadArray is not a function #14878 — sibling fix for @aws-amplify/datastore (declare tslib ^2.1.0)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 50f5282

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR