test: remove deprecated import violations test#5313
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the now-redundant Go test that enforced deprecated graft import rules, since those constraints are handled by Bazel visibility after #5304.
Changes:
- Deleted
vms/evm/imports_test.go(the import-violation scanning test). - Removed the corresponding Bazel
go_testtarget by deletingvms/evm/BUILD.bazel.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
vms/evm/imports_test.go |
Removes the deprecated import-violations test logic. |
vms/evm/BUILD.bazel |
Removes the Bazel test target that only existed to run imports_test.go. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maru-ava
approved these changes
Apr 29, 2026
powerslider
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
With the merge of #5304, this test is now wholly redundant.
See this comment for more information.
How this works
Deletes everything.
How this was tested
N/A
Need to be documented in RELEASES.md?
No