fix: add missing exception chaining (from e) in 3 files [BLDX-992]#1312
Merged
vaibhavatlan merged 2 commits intorefactor-v3from Apr 14, 2026
Merged
fix: add missing exception chaining (from e) in 3 files [BLDX-992]#1312vaibhavatlan merged 2 commits intorefactor-v3from
vaibhavatlan merged 2 commits intorefactor-v3from
Conversation
Redis error handler, credentials JSON parser, and credential resolver all raised wrapped exceptions without chaining the original cause, losing traceback context needed for debugging.
vaibhavatlan
requested review from
OnkarVO7,
cmgrote and
louisnow
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 80.6%) Detailed Coverage Report |
📦 Trivy Vulnerability Scan Results
Report SummaryCould not generate summary table (data length mismatch: 9 vs 8). Scan Result Detailsrequirements.txtuv.lock |
📦 Trivy Secret Scan Results
Report SummaryCould not generate summary table (data length mismatch: 9 vs 8). Scan Result Detailsrequirements.txtuv.lock |
Collaborator
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
🛠 Docs available at: https://k.atlan.dev/application-sdk/BLDX-992 |
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/1312 |
vaibhavatlan
added
refactor-v3
Autonomous SDK Evolution
vaibhavatlan
commented
Apr 14, 2026
Collaborator
Author
vaibhavatlan
left a comment
vaibhavatlan
left a comment
There was a problem hiding this comment.
SDK Review: All checks pass. APPROVED.
All three exception chaining gaps are correctly addressed: from e / from exc is added to every raise site in clients/redis.py, common/utils.py, and credentials/resolver.py. This is a non-behavioral correctness fix (exception __cause__ chain is preserved for debugging without changing runtime behavior). No new tests are required per policy for this category.
One observation (pre-existing, outside this diff): the Redis error handler embeds {e} in the new exception message string AND now chains the original exception via from e. Both convey the same information; the message string is redundant but not harmful. Flagging for awareness only — not a blocker.
vaibhavatlan
added
ready-to-merge
vaibhavatlan
commented
Apr 14, 2026
Collaborator
Author
vaibhavatlan
left a comment
vaibhavatlan
left a comment
There was a problem hiding this comment.
All 4 reviewers confirm — ready for human merge
- Architecture: APPROVED
- Code Quality: APPROVED
- Security: APPROVED
- Test Quality: APPROVED
No Critical findings. All review feedback addressed. All tests passing.
cmgrote
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was found
Rule: BUG-015 / QUAL-EXC-CHAIN
Files:
clients/redis.py:25,common/utils.py:505,credentials/resolver.py:96Severity: high
Three locations raise wrapped exceptions without
from e:_handle_redis_error()— all 4 raise branches lose original Redis errorparse_credentials_extra()— loses JSON parse error detailsCredentialResolver.resolve()— loses SecretNotFoundError contextWhat was fixed
Added
from e/from excto all raise statements, preserving exception chains.Validation
Linear
https://linear.app/atlan-epd/issue/BLDX-992