refector all code and improve some UI#4
Open
hyderly wants to merge 1 commit intoashutosh1919:masterfrom
Open
Conversation
Owner
|
Auto formatting the code is required. I am working on it. Because of auto-prettifying the code, the code has so many changes in this PR. |
bikkimahato
reviewed
Jan 12, 2022
bikkimahato
left a comment
bikkimahato
left a comment
There was a problem hiding this comment.
A lot of code format changes are there.
Comment on lines
+29
to
+48
| <Main onToggle={toggleTheme} theme={theme} /> | ||
| </> | ||
| </ThemeProvider> | ||
| // <div className="App"> | ||
| // <header className="App-header"> | ||
| // <img src={logo} className="App-logo" alt="logo" /> | ||
| // <p> | ||
| // Edit <code>src/App.js</code> and save to reload. | ||
| // </p> | ||
| // <a | ||
| // className="App-link" | ||
| // href="https://reactjs.org" | ||
| // target="_blank" | ||
| // rel="noopener noreferrer" | ||
| // > | ||
| // Learn React | ||
| // </a> | ||
| // </header> | ||
| // </div> | ||
| ); |
There was a problem hiding this comment.
Commented code should not be pushed.
Comment on lines
+19
to
+22
| if (props.from === "tech") return <TechList />; | ||
| else if (props.from === "design") return <DesignList />; | ||
| else if (props.from === "motivation") return <MotivationList />; | ||
| else if (props.from === "selfbranding") return <SelfBrandingList />; |
There was a problem hiding this comment.
Better way of doing this would be use of switch case.
Owner
There was a problem hiding this comment.
@bikkimahato , Thanks for suggestions. Feel free to raise PR to resolve these issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope I will contribute more in the future.