Real E2E tests

[gregberge]

Still missing the ability to run them in parallel

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	⚠️ Changes detected (Review)	8 changed, 4 added, 20 removed, 20 failures	Apr 6, 2026, 4:30 PM

[Copilot]

Pull request overview

Adds initial Playwright E2E coverage for logged-in account settings by introducing a DB seed “setup” project and a reusable logged-in test fixture, while also tightening slug validation and improving accessibility of settings UI regions.

Changes:

• Add Playwright setup + logged-in fixture and initial account settings E2E specs.
• Centralize slug validation via a shared SLUG_REGEX and reuse it in frontend validation + util tests.
• Update CI/docs/scripts to rely on Playwright setup instead of a separate e2e:setup step; add a11y attributes to settings UI.

Reviewed changes

Copilot reviewed 23 out of 25 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tests/seed.setup.ts	New Playwright setup test to truncate + seed the DB before E2E projects run.
tests/logged-test.ts	New loggedTest fixture that logs in by setting an argos_jwt cookie and selects an account per worker.
tests/account.spec.ts	New E2E tests for personal settings name + username flows.
playwright.config.mts	Configure fixed worker count, add setup project dependency, set NODE_ENV=test for the webServer.
playwright/.auth/user.json	Adds a Playwright storage state file containing a JWT cookie.
packages/util/src/slug.ts	Introduce SLUG_REGEX and use it for JSON schema pattern.
packages/util/src/slug.test.ts	Update tests to assert against SLUG_REGEX.
packages/util/package.json	Add @sindresorhus/slugify to this package manifest.
pnpm-lock.yaml	Lockfile updates for moved/added slugify dependency.
apps/frontend/src/ui/FormSuccess.tsx	Add live-region semantics for success feedback.
apps/frontend/src/containers/Account/ChangeSlug.tsx	Use shared SLUG_REGEX; add region labeling for accessibility.
apps/frontend/src/containers/Account/ChangeName.tsx	Add region labeling for accessibility.
apps/backend/src/util/email.ts	Switch slugify import to @argos/util/slug.
apps/backend/src/graphql/context.ts	Adjust test-mode mocked auth handling.
apps/backend/src/database/util/model.ts	Refactor Objection knex initialization into a helper.
apps/backend/src/database/services/team.ts	Switch slugify import to @argos/util/slug.
apps/backend/src/database/services/account.ts	Switch slugify import to @argos/util/slug.
apps/backend/src/database/models/Account.ts	Switch slug schema import to @argos/util/slug.
apps/backend/src/database/knex.ts	Refactor knex construction into a helper function.
apps/backend/package.json	Remove @sindresorhus/slugify from backend package deps.
package.json	Remove e2e:setup script.
.github/workflows/ci.yml	Remove explicit DB seed step before Playwright (now handled by setup project).
knip.json	Ignore the new Playwright setup test file for knip.
CONTRIBUTING.md	Remove manual E2E setup step from contributor docs.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.