feat: add offline DuckLake service wiring - #488
Conversation
|
Known limitation (CTO, 2026-08-28): DuckDB 1.5.5 This does not block merging this PR as default-off: default-off does not create secrets and does not change current main behavior. Until replica isolation lands in a later 0.3 follow-up:
Do not retouch this head for that limitation. After merge, open a follow-up issue and assign it. |
|
Cannot merge this head ( Hosted copy-instance and Docker replica mysql/mariadb are candidate-only reds vs parent CTO also requires rejecting Replica-visible database-global secrets remain a known limitation and do not block default-off merge. Need a new platform-signed head on the same parent, independent review of that exact OID, and no new reds vs parent. |
Task #71 follow-up: allow hosted MySQL executable comments that carry ordinary CREATE DATABASE clauses, while rejecting persistent secret creation. This replacement changes only catalog/sensitive_sql.go and is based on the existing signed PR head.
|
Follow-up replacement head for the two pre-merge lexer fixes:
The scanner now parses MySQL Exact-head checks passed: catalog sensitive boundary, tagged backend sensitive/parser tests, tagged pgserver compile, and a disposable executable-comment probe. PR remains open for independent review. |
27c9698 to
3e3be67
Compare
leon-ape
left a comment
There was a problem hiding this comment.
Independent approval for exact head 3e3be67 (parent 9b9a5ef, tree cdfcb7dc831b07a27136ce6cc026dd94d49293dd). Reviewed task #80 evidence: FlightSQL concurrent/eviction/prepared-transaction checks exit 0 (log 15be53664c318bd915cb9ba98ab6551a0039b51c8d706a76827cb2aa435bfcb5), configuration default-off/redaction exit 0 (log 4b93845f8f5d23b60fa27889cb8a2b7c17c4bad67275d7f038734ece6fc3abca), and hosted backend audit-redaction pass; the local ICU failure is environment-only. Approval is limited to this exact OID and the agreed scope.
Task #71: offline DuckLake/httpfs service wiring, rebased onto current main.
Exact identity:
The head preserves the reviewed default-off behavior, service-only S3 credential injection, connection lifecycle coverage, and fixed offline extension hashes. Existing parent-baseline connection-refused harness failures are unchanged; focused gates and compile-only checks passed.
This PR is intentionally separate from task #75 table-selection work. Do not publish or alter v0.2.0/latest from this change without the project release decision.
Known limitation
DuckDB 1.5.5
CREATE SECRETis database-global. With lake enabled, a replica connection can observe the service secret even though replica origin is zero-inject. Default-off does not create secrets and does not change current main behavior, so this does not block merging as default-off.Until replica isolation lands in a later 0.3 follow-up: do not default-on this feature, do not add it to recommended config, and do not enable lake in environments that have replica consumers.