fix: support Dolt 2.3.1 GTID replication - #480
Merged
Merged
Conversation
weicao
force-pushed
the
feature/dolt-2.3.1-support
branch
3 times, most recently
from
August 23, 2026 20:52
cc2eb55 to
b91cc2a
Compare
weicao
force-pushed
the
feature/dolt-2.3.1-support
branch
from
August 24, 2026 20:06
b91cc2a to
cbd566f
Compare
weicao
force-pushed
the
feature/dolt-2.3.1-support
branch
from
August 24, 2026 20:11
dfedb54 to
cbd566f
Compare
weicao
force-pushed
the
feature/dolt-2.3.1-support
branch
from
August 24, 2026 21:04
3a0d73b to
cbd566f
Compare
weicao
added a commit
that referenced
this pull request
Aug 26, 2026
Pin the Docker builder to the Go 1.26.2 bookworm multi-arch digest and install ICU build/runtime libraries required by the current dependency graph. Full arm64 and amd64 image builds, initialization, dynamic-library checks, and version checks passed locally. Keep this infrastructure change independent from PR #480.
weicao
added a commit
that referenced
this pull request
Aug 26, 2026
Pin the Docker builder to the Go 1.26.2 bookworm multi-arch digest and install ICU build/runtime libraries required by the current dependency graph. Full arm64 and amd64 image builds, initialization, dynamic-library checks, and version checks passed locally. Keep this infrastructure change independent from PR #480.
Review-only Dolt 2.3.1 replication update rebuilt directly on post-#484 main ba80562. Includes the six-file current-tree replay, isolated replication resources, and fresh candidate/parent four-source evidence. Do not merge, enable auto-merge, publish images, or move release tags without a new independent review.
weicao
force-pushed
the
feature/dolt-2.3.1-support
branch
from
August 26, 2026 11:30
d54fcc1 to
e20e51b
Compare
leon-ape
approved these changes
Aug 26, 2026
leon-ape
left a comment
Collaborator
There was a problem hiding this comment.
Independent review approved for exact signed head e20e51b (tree 26c91f5ffefec93fccf1149fd175e91b80c94c03). Reviewed the six-file diff, frozen candidate/parent evidence, hosted four-source replication matrix, exact-parent CI baselines, and fresh local focused/repeated/race/build/static gates. No merge, auto-merge, release, tag, or image action taken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review-only Dolt 2.3.1 replication update
This PR is the post-#484 rebuild of the Dolt 2.3.1 replication change. It is
not a release or merge authorization.
Locked identity
e20e51bc77345d898ae3dd4c6f7cfcd03986348bba805622a2b0c855e904e44e158112b216c8724b26c91f5ffefec93fccf1149fd175e91b80c94c03verified=true,reason=valid+977/-259e7ae857904d85463951dce5a85450455b9a4152b850d265725be3b46a9039d1ef6ab77f8c613421628ccf7633cf97b7b4c936d954ab8be95a6babc7f060e8153The parent is the merged PR #484 Dockerfile fix (
ba805622); the Dockerfileis not part of this PR. Rejected heads
3a0d73b5,d54fcc18, and localunsigned
bce4878are not in the signed commit ancestry. Old approvals do nottransfer.
Implementation boundary
The applier preserves main's QueryFlush barrier, reconnect transaction discard,
encoded/current file-position loading, two-argument non-Dolt dump path, and
transaction ordering. It adds only dual Dolt identity detection and
BinlogThroughGTID(0x04) for confirmed Dolt 2.3.1 MySQL56 GTID positions.The replication script now suffixes both container names and uses those names
for all Docker operations and DSNs, preventing concurrent collisions and
cleanup of pre-existing fixed-name containers.
Fresh evidence
myduckserver:task61-post484:sha256:cd15802b761da1f4ee6763c0bbcc7c094f7f07375cc6a2803ad91dca677405c9myduckserver:task61-parent-ba805:sha256:518653912d43d5bd9aab96abce9c8606f54f319093da6d80403b6569a107c5eeexact rows 2 -> 3 -> 4 -> 5, GTID through
:1-8, IO/SQL Yes, errno 0.got 7); initial/incremental errno 0.
Last_SQL_Errno=1105unknown-event baseline.
boundary; this is shared replication behavior, not candidate-only.
compile-only tests, build, tidy, format, shell syntax, ShellCheck and
diff-check pass. Two static rounds are recorded as
0b5159a7b0495d1e2df1c470d55c370877247438a9a7357365b114cccbafb802and8529f7135ceb56aaa7adc7dfb9e9ce12894ff344eb5b0720d2967cf2d8597ef9.go run .service never listened; all fixtures failed with connectionrefused before product assertions. This is environment evidence, not a
candidate-only regression. The precompiled candidate/parent package result
is the shared AutoRestartReplica
1105/ row-event flag0x10baseline.Do not merge, enable auto-merge, publish an image, move a release tag, or move
latestfrom this PR. A new independent non-author review must bind this exacthead before any integration decision.